February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #22 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Jonathan Druart from comment #16) > (In reply to Josef Moravec from comment #15) > > I tested these patches and they work fine for me. I found just few issues: > > when I tried to upload "bad" file (pdf, too big jpg, etc.), the file is not > > uploaded (of course) but no error message appears... Also I wasn't able to > > see "Image not imported because this patron does not exist in > > the database" error message. > > > > Maybe I'm doing something wrong... there are error messages in templates as > > I can see... > > Did you test without this patchset? > Just to know if I have to submit follow-ups or open a new bug report. I've just tested it on clean master and there is the same issue. So as it looks that it's not related with these patches, I'm signing off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48117|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 48140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48140&action=ed… Bug 15635: Change method type to _type for bug 15446 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48116|0 |1 is obsolete| | --- Comment #20 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 48139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48139&action=ed… Bug 15635: Koha::Patron::Images - Remove GetPatronImage To retrieve a patron image, we can call Koha::Patron::Images->find or Koha::Patrons->find->image Both will return a Koha::Patron::Image object. Test plan: 1/ From the patron/member module, open all tabs on the left (Checkouts, detail, fines, etc.) The image should be correctly displayed. 2/ At the OPAC, on the patron details page (opac-memberentry.pl) the image should be displayed as well. 3/ Same on the sco module. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48115|0 |1 is obsolete| | --- Comment #19 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 48138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48138&action=ed… Bug 15635: Koha::Patron::Images - Remove RmPatronImage The C4::Members::RmPatronImage just removed a row in patronimage. This can be accomplished using the delete method of Koha::Patron::Image. Test plan: >From the patron defail page, try to delete the image of a patron. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48114|0 |1 is obsolete| | --- Comment #18 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 48137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48137&action=ed… Bug 15635: Koha::Patron::Images - Remove PutPatronImage The C4::Members::PutPatronImage inserted/updated the image of a patron. This can be done easily with ->find->set->store or ->new->store Test plan: 1/ Modify the image of a patron from the patron detail page 2/ Add an image to a new patron 3/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of a patron 4/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of several patrons, using a zip file. Stress the script trying to get as many errors as possible (wrong cardnumber, wrong mimetype, file does not exist, etc.) With this patch, if the cardnumber does not exist, you will get a specific error "Image not imported because this patron does not exist in the database" Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48113|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 48136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48136&action=ed… Bug 15635: Koha::Patron::Images - Add new classes There are 3 subroutines in C4::Members to get, add and delete patron images: - GetPatronImage - PutPatronImage - RmPatronImage By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8352] Add automatic printing of 'hold to pull' notices
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #101 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #98) > Patches rebased, conflicts in notices sql files fixed! > > QA comments: > 1/ > FAIL Koha/Printer.pm > FAIL critic > "$pdf_data" is declared but not used at line 61, column 9. > Unused variables clutter code and make it harder to read. Ok fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8352] Add automatic printing of 'hold to pull' notices
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #100 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48135&action=ed… Bug 8352: Fix type vs _type for bug 15446 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8352] Add automatic printing of 'hold to pull' notices
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #99 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48134&action=ed… Bug 8352: Fix perlcritic '$pdf_data' is declared but not used -- You are receiving this mail because: You are watching all bug changes.

1 0