March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think we left the door open for non-OO modules atm - so I think this one should be ok from the phrasing in the coding guidelines. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #11 from Blou <philippe.blouin(a)inlibro.com> --- Interesting, that's the first explanation I have about C4 vs Koha namespace. I always thought C4 was "old crap" and Koha was "new better". Still, I don't understand the obsession toward OOing everything, especially in a non-OO language like Perl. Java created many obsessive behaviors and even more ugly projects because of its misunderstood OO paradigm. (I'm not calling our QA as having OCD, btw :-) I'll leave my 3 cents on this marvelous must-read article from an all-time great: http://www.drdobbs.com/cpp/how-non-member-functions-improve-encapsu/1844011… just because I like to plug it :-) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Nicole C. Engard <nengard(a)gmail.com> --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14577 - Allow restriction of checkouts based on fines of guarantor's guarantees Using index info to reconstruct a base tree... M C4/Circulation.pm M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Circulation.pm Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11360] Disable barcode field and submit button when a hold is found
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #39 from Owen Leonard <oleonard(a)myacpl.org> --- Unless there is a good case for hiding all messages, why not simply leave them there? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9805] Lost items are un-lost if returned, but not if renewed.
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #38 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #34) > t/db_dependent/Circulation/Renewal.t (Wstat: 65280 Tests: 2 Failed: 0) > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 7 tests but ran 2. All the tests passed for me! Can you please try again? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9805] Lost items are un-lost if returned, but not if renewed.
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #37 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48781&action=ed… Bug 9805 - Unit Tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9805] Lost items are un-lost if returned, but not if renewed.
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #36 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48780&action=ed… Bug 9805 - Update Schema -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9805] Lost items are un-lost if returned, but not if renewed.
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47617|0 |1 is obsolete| | Attachment #47618|0 |1 is obsolete| | Attachment #47619|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48779&action=ed… Bug 9805 - Lost items are un-lost if returned, but not if renewed. If an item has a lost status, that status is removed when the item is returned. However, it is not removed if the item is renewed. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circ rules 4) Note the "Renew lost?" and "Renewal marks lost found" rules 5) Set and test each of the rules both ways for the rules for all libraries 6) Repeat but for a specific branch this time Signed-off-by: Paul Poulain <paul.poulain(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9805] Lost items are un-lost if returned, but not if renewed.
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11360] Disable barcode field and submit button when a hold is found
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #38 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Owen Leonard from comment #37) > (In reply to Kyle M Hall from comment #36) > > Which part of comment 27? > > The whole thing! > > 1. The dialog obscures any other messages which might be displayed during > checkin, then hides those messages when the dialog is dismissed. > > 2. The patch reverts the changes made by Bug 15670. Let's focus on point 1 for now. What would you suggest as a fix for that? -- You are receiving this mail because: You are watching all bug changes.

1 0