March 2016 - Koha-bugs - lists.koha-community.org

[Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874)
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Bug 14686 has been submitted now.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49259|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49261&action=ed… Bug 14686: Add Upload to Tools menu This patch makes sure that the added granular permissions work as advertised. Note: The field owner was not included in the Koha::Upload->get response. The code to verify if a user is allowed to delete an upload, is concentrated in the template now. When get returns a Koha::Object, this check could be relocated. Test plan: [1] Verify that the current user has permission for tools, or has at least upload_general_files. [2] Do you see Upload in the Tools menu? Follow the link. [3] Upload a permanent file (with a category). [4] Do you see the Delete button in the results form? [5] Make sure that another user has no permission to upload. [6] Login as that user and check the Tools menu. Try the URL [yourserver]/cgi-bin/koha/tools/upload.pl You should have no access to the upload form. [7] Enable upload_general_files for this user. Go to upload and search for the upload from step 3. You should not see a Delete button. [8] Enable upload_manage for this user. Search for the upload again. Delete the upload. [9] Go to upload via the Cataloguing editor (856$u plugin) or add parameter "plugin=1" to the URL. You should not see the Tools menu. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49258|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49260&action=ed… Bug 14686: Add two granular permission for upload under tools [1] Upload_general_files This will allow you to access the tools/upload form via the Tools menu. And it will also allow you to add permanent uploads. [2] Upload_manage It will allow you to delete uploads from other users. Note that anyone may delete his own uploads. It is not meant to include upload_general_files. In order to not disturb existing users that now have edit_catalogue and are using the plugin (read: added at least one record to uploaded_files), we will add the first permission for them. New users will need to be authorized in the usual way thereafter. Note: If you only have one of the other permissions checked in allows_add_by, e.g. stage_marc_import, you can add temporary uploads, but not permanent uploads. Test plan: We are only testing the dbrev here, not if the perm works as advertised. [1] Run the dbrev and check that you see the perms with a description on the Patron/Set permissions page. [2] If you had records in uploaded_files and a user with edit_catalogue *only*, verify that this user now also has upload_general_files. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14695] Add ability to place multiple item holds on a given record per patron
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Mike <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |black23(a)gmail.com --- Comment #81 from Mike <black23(a)gmail.com> --- Could You rebase? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15756 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 [Bug 15756] Some tests for haspermission in C4::Auth -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15756] New: Some tests for haspermission in C4::Auth
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Bug ID: 15756 Summary: Some tests for haspermission in C4::Auth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: gmcharlt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #4 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49259&action=ed… Bug 14686: Add Upload to Tools menu This patch makes sure that the added granular permissions work as advertised. Note: The field owner was not included in the Koha::Upload->get response. The code to verify if a user is allowed to delete an upload, is concentrated in the template now. When get returns a Koha::Object, this check could be relocated. Test plan: [1] Verify that the current user has permission for tools, or has at least upload_general_files. [2] Do you see Upload in the Tools menu? Follow the link. [3] Upload a permanent file (with a category). [4] Do you see the Delete button in the results form? [5] Make sure that another user has no permission to upload. [6] Login as that user and check the Tools menu. Try the URL [yourserver]/cgi-bin/koha/tools/upload.pl You should have no access to the upload form. [7] Enable upload_general_files for this user. Go to upload and search for the upload from step 3. You should not see a Delete button. [8] Enable upload_manage for this user. Search for the upload again. Delete the upload. [9] Go to upload via the Cataloguing editor (856$u plugin) or add parameter "plugin=1" to the URL. You should not see the Tools menu. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #3 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49258&action=ed… Bug 14686: Add two granular permission for upload under tools [1] Upload_general_files This will allow you to access the tools/upload form via the Tools menu. And it will also allow you to add permanent uploads. [2] Upload_manage It will allow you to delete uploads from other users. Note that anyone may delete his own uploads. It is not meant to include upload_general_files. In order to not disturb existing users that now have edit_catalogue and are using the plugin (read: added at least one record to uploaded_files), we will add the first permission for them. New users will need to be authorized in the usual way thereafter. Note 1: If you have edit_catalogue, you can also use the form via the plugin in the cataloguing editor, but you can only search for uploads if you do not have upload_general_files. (This change of behavior triggered adding the permission for current users.) Note 2: If you only have one of the other permissions checked in allows_add_by, e.g. stage_marc_import, you can add temporary uploads, but not permanent uploads. Test plan: We are only testing the dbrev here, not if the perm works as advertised. [1] Run the dbrev and check that you see the perms with a description on the Patron/Set permissions page. [2] If you had records in uploaded_files and a user with edit_catalogue *only*, verify that this user now also has upload_general_files. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '16

17 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #2 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49257&action=ed… Bug 14686: Add allows_add_by to check permissions for uploading The three permissions in tools/upload-file.pl are moved to a custom routine in DBIx's UploadedFile.pm. An additional granular permission upload_general_files is added. (The dbrev patch will contain it too.) At some point in time this could be moved to a Koha::Object class. The routine is tested in Upload.t. Test plan: [1] Run t/db_dependent/Upload.t [2] If you only apply this patch, you can also test uploading with a user that has edit_catalogue but does not have tools or circulate. Upload status should say: Denied. -- You are receiving this mail because: You are watching all bug changes.

1 0