April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- > NOTE: Further investigation determined this would merely > delay it, as the function is not called by this test. > A delay is better than nothing. I do not have the time right now to investigate but I disagree with this note. The carp occurs because some shibboleth stuffs are done in the BEGIN block of C4::Auth. I don't think we want to skip the evaluation at compilation time here for this module. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12267] Allow password option in Patron Attribute non functional
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- @Rm Please update schema files. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I don't understand, on both interface I do not get the "no image" amazon image if [OPAC]LocalCoverImages prefs are set. Please detail how you get the before/after pic -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50595&action=ed… Bug 14632: Add Copyright for the Koha Dev Team Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 --- Comment #21 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50594&action=ed… Bug 14362: Regression tests This should trigger the error. Attempts to shift system time zones did not make sense as to the number of failures. Added Time::Fake dependency, if it isn't installed these extra tests don't run. There is a nice skip message about it. Added License text. TEST PLAN --------- 1) apply test patch 2) sudo dpkg-reconfigure tzdata -- set your system time to GMT (Africa/Abidjan) 3) prove t/Circulation/AgeRestrictionMarkers.t -- should not fail, even if you change system time to any time. 4) sudo dpkg-reconfigure tzdata -- set your timezone to Eastern 5) sudo date -s"2015-06-18 21:15:00" 6) date -- should be past 9pm Eastern timezone 7) prove t/Circulation/AgeRestrictionMarkers.t -- kaboom! 8) sudo date -s"2015-06-18 12:00:00" 9) date -- should be noon Eastern timezone 10) prove t/Circulation/AgeRestrictionMarkers.t -- success?! Time sensitive tests are bad tests. 11) sudo apt-get install libtime-fake-perl 12) prove t/Circulation/AgeRestrictionMarkers.t -- kaboom! -- changing timezone to anything other than GMT should trigger a kaboom. 13) apply fix patch 14) prove t/Circulation/AgeRestrictionMarkers.t -- should work all the time. 15) less t/Circulation/AgeRestrictionMarkers.t -- the license text should be similar to http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence 16) koha qa test tools. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50555|0 |1 is obsolete| | Attachment #50556|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50593&action=ed… Bug 14362: PEGI15 Circulation/AgeRestrictionMarkers test fails It is best to test when UTC date is a date in the future compared to your timezone. I'm in Eastern, so right now, I expect this test to fail for another 2.5 hours. TEST PLAN --------- 1) prove t/Circulation/AgeRestrictionMarkers.t -- fails for PEGI 15 after 9pm. 2) Apply patch 3) prove t/Circulation/AgeRestrictionMarkers.t -- works. 4) koha qa test tools Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15044] add suggestion's date on Your purchase suggestions tab in OPAC
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15044 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16328 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16328 [Bug 16328] datatables on opac-suggestions.pl broken by js error -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5979] Add separate OPACISBD system preference
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #47 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed last patch from Mtompsett (thanks!) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5979] Add separate OPACISBD system preference
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '16

23 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #46 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 50591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50591&action=ed… Bug 5979: Follow up on systempreferences.sql Missing comma, extra comma, and bad placement -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0