April 2016 - Koha-bugs - lists.koha-community.org

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50416|0 |1 is obsolete| | --- Comment #31 from Marc Véron <veron(a)veron.ch> --- Created attachment 50420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50420&action=ed… Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> New sign-off, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50364|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 50417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50417&action=ed… [SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Looks like refactoring :) No regressions, no koha-qa errors Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #30 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Fixed conflicts -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14695] Add ability to place multiple item holds on a given record per patron
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #99 from Owen Leonard <oleonard(a)myacpl.org> --- I don't see any changes to opac-reserve.tt. How can one place holds on multiple items if the form in the OPAC hasn't been updated to allow for multiple selections? Also, I get an error in the staff client: 1. Search for a title to place a hold on. 2. Click the "Place hold" link in search results. 3. Submit a patron barcode to place the hold for. Error: Template process failed: undef error - WHILE loop terminated (> 1000 iterations) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40889|0 |1 is obsolete| | Attachment #48649|0 |1 is obsolete| | Attachment #50415|0 |1 is obsolete| | --- Comment #29 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 50416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50416&action=ed… Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #28 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 50415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50415&action=ed… Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50410|0 |1 is obsolete| | --- Comment #15 from Marc Véron <veron(a)veron.ch> --- Created attachment 50414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50414&action=ed… Bug 3534 - Fix tabs to spaces Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50362|0 |1 is obsolete| | --- Comment #14 from Marc Véron <veron(a)veron.ch> --- Created attachment 50413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50413&action=ed… Bug 3534 - Patron quick add form This patch adds a new system preference: PatronQuickAddFields When either this pref or BorrowerMandatoryField is populated this will add a new dropdown to the bew patron toolbar. When a category is chosen from this dropdown the fields in PatronQuickAddFields and BorrowerMandatoryField will be displayed. There will be a button allowing a user to switch from the quickadd to the full form and fields will be copied between the forms when toggling. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields and note the new button for adding a patron 5 - Click the Quick add and choose a type 6 - Only required or quick add fields should be displayed 7 - Verify toggling forms copies information 8 - Ensure you cannot save patron without filling required fields (quick add fields should be optional) 9 - Ensure you can save patron with fields filled out 10 - Ensure that a duplicate patron brings up the duplicate/add new buttons with full form displayed 11 - Verify that subsequent edits use only full form 12 - Verify that data on form submitted is the data saved to patron 13 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0