April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49406|0 |1 is obsolete| | Attachment #50326|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50389&action=ed… Bug 15534 - Add the ability to prevent a patron from placing a hold on a record with available items Some libraries would like to prevent patrons from placing holds on items where there are other items available for the patron to check out. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circulation rules 4) Note the new option for "On shelf holds allowed" 5) Set the rule to "If all unavailable", set "item level holds" to allow 6) Find a patron/branch/itemtype applicable to this rule 7) Ensure at least one item on the record is available for the patron to check out 8) Attempt to place a hold for the item 9) Note you cannot place the hold 10) Check the available item out to another patron 11) Note you can now place a hold for the first patron Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> Works as intended! Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #24) > (In reply to Jonathan Druart from comment #23) > > (In reply to Jonathan Druart from comment #19) > > > Should not we check the "Reserved" status? > > > > And what about the "Reserved" status? > > The code already checks to see if the item is a waiting hold. Is this not > what you are referring to? I was thinking about the "Reserved" status returned by GetReserveStatus, but after a night's sleep, I don't think it's needed actually. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I don't need anything else (for bug 15705) apart from the patches from this bug report. But I think it would be good to agree on the next steps. For instance, my note on comment 31 is still valid: > We cannot update the notices with the TT syntax and set the pref off by default. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #67 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Florent Mara from comment #66) > As part of an effort to improve performance when importing borrowers, I have > started working on top of the current patches. > Steps proposed are as follows: > > (1) Resolve merge conflicts from pre-existing patches. (Completed) > (2) Add regression tests to new Koha::Patrons::Import. (Completed) > (3) Refactor Koha::Patrons::Import + further regression testing. ( In > progress ) > (4) Review import_borrowers.pl and Koha::Patrons::Import for further > improvements. (To do) > > Any feedback welcomed. Good to heard that :) Don't forget to share your patches ASAP -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #12 from Marc Véron <veron(a)veron.ch> --- Works great now, However QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt FAIL forbidden patterns forbidden pattern: tab char (line 277) forbidden pattern: tab char (line 840) forbidden pattern: tab char (line 272) forbidden pattern: tab char (line 831) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12267] Allow password option in Patron Attribute non functional
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267 --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am a bit worried about removing those - could we bring this up on the mailing list? Would it be possible that people used it as a hook to store login information other applications? When testing I noticed it stores the password in the database as cleartext, while hiding it **** in the GUI. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9393] Add note to circulation.pl if borrower has pending modifications
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Not a blocker, but a thing that could be improved: The link to "View all pending patron modifications" brings you to the modifications page - it would be nice if the patron you came from would be uncollapsed ready for you to edit. But something else: You might also not be able to see the entry for the patron because of IndependentBranchesPatronModifications - not sure how to handle this. Maybe we should only show the link of logged in branch and staff branch match? Sorry... maybe not the best morning for QA (first passing then putting back to Failed...) - but could you take another look? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9393] Add note to circulation.pl if borrower has pending modifications
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50339|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50384&action=ed… [PASSED QA] Bug 9393 - Add note to circulation.pl if borrower has pending modifications Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> New link "patron modifications" (if there are) on the checkout page. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9393] Add note to circulation.pl if borrower has pending modifications
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '16

19 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0