April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15471] Add column settings and filters to Holds queue table
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Benjamin Rokseth from comment #15) > Eh, this is already committed to master, no? Yep! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16237 [Bug 16237] Adding new EDI account results in Perl error -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13216] fix koha-shell to work with git/dev installs
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 --- Comment #9 from Liz Rea <liz(a)catalyst.net.nz> --- I feel like that's a bit of scope creep - but I"m not opposed to adding something like a "check if gitified" function. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15331] Sort order breaks at offset=1000 (both OPAC and Intranet)
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 --- Comment #4 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Nick Clemens from comment #3) > Is this valid then, or does sortmax/bug 7041 solve this? sortmax would allow you to sort more records, but it'll always be a limitation, I think. I wonder if there's a way to specify sort all... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13216] fix koha-shell to work with git/dev installs
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 --- Comment #8 from Mason James <mtj(a)kohaaloha.com> --- (In reply to Mason James from comment #7) > (In reply to Marcel de Rooy from comment #4) > > This is an interesting change. > > I added an see-also to a blocked bug 13971 from myself. I was not yet > > satisfied with the solution there. > > > > Instead of passing the kohadir on all individual scripts like koha-shell > > here, koha-rebuild-zebra or even another one in the other see-also, imo we > > would benefit from a more general approach. > > The get_perl5lib function in koha-functions.sh would do (from 13971); we > > should forget the other function is_gitified. > > > > Instead of passing the alternative path all the time, why not once record it > > in koha-conf.xml ? What do you think ? > > just my 2 cents... we need to know 2 things here... > > 1/ what the base directory of the Koha is? > 2/ what kind of install type the Koha is? (eg: tar, git, .deb), as the > directory structure is difference for each type > > we do need something like a is_gitified() function, that checks the > koha-conf.xml file for some value > > knowing the base directory of the Koha, and 'guessing' the install type - > wont give us enough info to sort this problem? specifically scripts like koha-update-schema and koha-translate will need to know these 2 things, to work correctly with a gitified Koha; as the dir structure is different for each type -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13216] fix koha-shell to work with git/dev installs
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 --- Comment #7 from Mason James <mtj(a)kohaaloha.com> --- (In reply to Marcel de Rooy from comment #4) > This is an interesting change. > I added an see-also to a blocked bug 13971 from myself. I was not yet > satisfied with the solution there. > > Instead of passing the kohadir on all individual scripts like koha-shell > here, koha-rebuild-zebra or even another one in the other see-also, imo we > would benefit from a more general approach. > The get_perl5lib function in koha-functions.sh would do (from 13971); we > should forget the other function is_gitified. > > Instead of passing the alternative path all the time, why not once record it > in koha-conf.xml ? What do you think ? just my 2 cents... we need to know 2 things here... 1/ what the base directory of the Koha is? 2/ what kind of install type the Koha is? (eg: tar, git, .deb), as the directory structure is difference for each type we do need something like a is_gitified() function, that checks the koha-conf.xml file for some value knowing the base directory of the Koha, and 'guessing' the install type - wont give us enough info to sort this problem? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50047|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 50100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50100&action=ed… Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar This patch moves all the code into an include which can be accessed from the 'Add a new message' link or the patron toolbar. EDIT: Ensuring modal opens on all pages EDIT2: Once the form has been submitted the page will redirect to where you submitted the form from. EDIT3: Fixing indentation of member-add-message.inc Ensuring messages save on every page Fill branch Ensure predefined notes appear Form redirects to where it was submitted from, or just the circulation page. EDIT4: Removing the new include file and moving it all into the modal in the toolbar EDIT5: Removing swp file and unnecessary code duplication by utilising plugins To test: 1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X) 2) Click 'Add a new message' under Messages 3) Confirm this brings up the modal to add a message. Confirm clicking Save saves your message. If it is an OPAC message (for the user), confirm it shows as expected on the OPAC. 4) Click Cancel. Confirm this closes the modal. 5) Click 'Add message' button in toolbar. Complete steps 3 and 4. 6) Confirm the modal opens from all other pages with the members toolbar. Confirm predefined notes shows. circ/circulation.pl members/moremember.pl members/routing-lists.pl members/statistics.pl members/boraccount.pl members/pay.pl members/maninvoice.pl members/mancredit.pl members/readingrec.pl members/notices.pl members/member-flags.pl members/member-password.pl members/paycollect.pl members/files.pl 7) Confirm that the page redirects to where you submitted the form from once you have submitted it. 8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you saved it) Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10607] JavaScript indexOf function not supported by IE 7 and 8
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 --- Comment #8 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Owen Leonard from comment #7) > That is, I don't think we should be spending time trying to support IE7 and > 8 anymore. I agree that there's no point in actively trying to support IE7 and IE8, although as someone who has to support IE7 and IE8 sometimes, I find it nice when people test and QA my code. What I mean to say is... in general we shouldn't claim to support IE7 or IE8 or make concerted efforts to do so... but I don't see why we can't fix individual issues as they arise if someone is willing to code a fix. Personally, I haven't encountered this particular issue, so I have no interest in fixing it if I don't have to, but I don't know if we need to label it as a WONTFIX. (Relevant for anyone searching this in the future: Personally, I think it makes sense to use jQuery's "inArray", since we use a lot of jQuery and it's cross-platform. Obviously not very useful in the case of third-party libraries that we can't re-write. Alternatively, we could use a polyfill: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objec…) -- You are receiving this mail because: You are watching all bug changes.

1 0