April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49963|0 |1 is obsolete| | --- Comment #90 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49978&action=ed… Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14816] Item search returns no results with multiple values selected for one field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49960|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 49977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49977&action=ed… Bug 14816: Fix multiple selection in item search Send each selected value as a separate parameter. Otherwise DataTables (or jQuery ?) joins all values with a comma Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> I could not reproduce the bug when selecting multiple home libraries, but I could by selecting multiple item types or collection codes. The patch allowed those queries to complete correctly. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14816] Item search returns no results with multiple values selected for one field
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8361] Issuing rule if no rule is defined
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #2) > (In reply to Jonathan Druart from comment #1) > > Is this still an issue? > > Why should we refuse checkouts if no rule is defined? > > Because that is expected behavior. If I don't put gas in the car, I don't > expect it to still drive. There are basic components that are just required. Yes exactly, so do not expect Koha to behave correctly if you did not configure it correctly :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 10089] Prevent renewing for restricted patrons
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10089 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #6 from Owen Leonard <oleonard(a)myacpl.org> --- I think this has been fixed by Bug 8236. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13576] Add a default circulation rule to the optional sample data
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13576 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- Why sample data? Why not a default behavior if no rules are present? Either reject transactions until all the pieces are in place, or have a hard set rule in place in case basic rules or a "catch all" is defined by admin. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8361] Issuing rule if no rule is defined
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to Jonathan Druart from comment #1) > Is this still an issue? > Why should we refuse checkouts if no rule is defined? Because that is expected behavior. If I don't put gas in the car, I don't expect it to still drive. There are basic components that are just required. I guess we could make Koha ask questions when certain things are missing, like when the item is due. If that were the only piece missing, that would be fine. But if there are no circ rules defined, chances are there is a lot more missing in setup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 9393] Fix bad label and add note to circulation.pl if borrower has pending modifications
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #7 from Owen Leonard <oleonard(a)myacpl.org> --- I think it would be better if the OPAC-related changes could be split into their own bugs. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15599] Unit tests output warnings
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47243|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49973&action=ed… Bug 15599: Unit tests output warnings The unit tests t/db_dependent/Circulation/Returns.t and t/db_dependent/Items.t print out eh warning "item-level_itypes set but no itemtype set for item". This should not happen. Test Plan: 1) prove t/db_dependent/Circulation/Returns.t 2) Note the warning 3) prove t/db_dependent/Items.t 4) Note the warning 5) Apply this patch 6) prove t/db_dependent/Circulation/Returns.t 7) Note there is no warning 8) prove t/db_dependent/Items.t 9) Note there is no warning Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Meaningful chages to the tests. Passes qa tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15599] Unit tests output warnings
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0