April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 --- Comment #21 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50960&action=ed… [PASSED QA] Bug 15531: Add support for standing orders This allows creation of special baskets that include standing orders. These orders do not have a known quantity (and may not have a known price in advance). Upon receipt, the received items are split into a new completed order. Test plan: 1) Run updatedatabase.pl. 2) Run prove t/db_dependent/Acquisition/StandingOrders.t . (and the other Acquisition tests). 3) Create a new basket, mark it as a standing order basket. 4) Add an order to this basket, and notice that the quantity field is missing (and thus not required). 5) Receive items for this order, and notice that the original order is unchanged. The new child order line should have the correct price and quantity information. (Note: the QA tools output what seems to be a spurious spelling error for Test::More's "isnt" in StandingOrders.t.) Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jesse Weaver from comment #19) > > 5) The order status of the order lines will remain 'new' (usually means: not > > send to the vendor, unfinished) as the basket is never closed, which would > > set it to 'ordered'. Should we use a new order status here? I think it would > > be good for searching and to help avoid confusion. Maybe 'standing'? > > > > I think this is a legitimate possible point of confusion, but the current > approach shouldn't cause any issues with workflow, and changing this patch > and the rest of acq to work with a new order status could be quite tricky. > Something to approach as a future enhancement? OK -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13903] Add API routes to list, create, update, delete holds
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50853|0 |1 is obsolete| | --- Comment #20 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 50959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50959&action=ed… Bug 13903: (QA followup) change routes to /holds GET /holds?borrowernumber=X (list) POST /holds (create) PUT /holds/{reserve_id} (update) DELETE /holds/{reserve_id} (delete) Unit tests in t/db_dependent/api/v1/holds.t Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 --- Comment #19 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- > 5) The order status of the order lines will remain 'new' (usually means: not > send to the vendor, unfinished) as the basket is never closed, which would > set it to 'ordered'. Should we use a new order status here? I think it would > be good for searching and to help avoid confusion. Maybe 'standing'? > I think this is a legitimate possible point of confusion, but the current approach shouldn't cause any issues with workflow, and changing this patch and the rest of acq to work with a new order status could be quite tricky. Something to approach as a future enhancement? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50955|0 |1 is obsolete| | --- Comment #18 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 50958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50958&action=ed… Bug 15531: (QA followup) Fix several small issues * Add `AFTER` to DB update * Change "Is standing order basket:" to "Orders are standing:" * Disable item creation when adding from basket * Correctly show is_standing for existing baskets -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50637|0 |1 is obsolete| | --- Comment #17 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 50957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50957&action=ed… Bug 15531: (followup) Use a quantity of 1, not null, for standing orders This seems to cause fewer problems with the existing acquisitions code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 --- Comment #16 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 50956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50956&action=ed… Bug 15531: Add support for standing orders This allows creation of special baskets that include standing orders. These orders do not have a known quantity (and may not have a known price in advance). Upon receipt, the received items are split into a new completed order. Test plan: 1) Run updatedatabase.pl. 2) Run prove t/db_dependent/Acquisition/StandingOrders.t . (and the other Acquisition tests). 3) Create a new basket, mark it as a standing order basket. 4) Add an order to this basket, and notice that the quantity field is missing (and thus not required). 5) Receive items for this order, and notice that the original order is unchanged. The new child order line should have the correct price and quantity information. (Note: the QA tools output what seems to be a spurious spelling error for Test::More's "isnt" in StandingOrders.t.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50636|0 |1 is obsolete| | --- Comment #15 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 50955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50955&action=ed… Bug 15531: (QA followup) Fix several small issues * Add `AFTER` to DB update * Change "Is standing order basket:" to "Orders are standing:" * Disable item creation when adding from basket * Correctly show is_standing for existing baskets -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #48 from Galen Charlton <gmcharlt(a)gmail.com> --- Data point: seems to work for me on a Jessie box. -- You are receiving this mail because: You are watching all bug changes.

1 0