May 2016 - Koha-bugs - lists.koha-community.org

[Bug 7706] AuthorisedValueImages not displaying all images on the OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 May '16

06 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- AuthorisedValueImages has been removed from the code recently - which makes this bug invalid. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 06 May '16

06 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan(a)bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 06 May '16

06 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51234|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 51266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51266&action=ed… [PASSED QA] Bug 13041 - Can't add user as manager of basket if name includes a single quote If you are trying to add a user as a manager of a basket in acquisitions, a JavaScript error will be triggered if that user has a single quote in their name (e.g. "O'Neil"). This patch corrects the issue by removing the "onclick" attribute and using the JS change made in Bug 16386. Also changed by this patch: Increased the size of the patron search popup and made a correction to some invalid HTML. To test you should have a patron whose name contains a single quote who is also a user with permission to manage acquisitions. - Apply the patch and go to Acquisitions. - Locate an open basket and view the details for that basket. - In the "Managed by" section, click the "Add user" button to trigger the patron search popup. - Search for the patron described above and click the "Add" button. - In the parent window, the patron you chose should have been added to the "Managed by" section. Tested on top of Bug 16383, behaves as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 06 May '16

06 May '16

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 06 May '16

06 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51234|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 06 May '16

06 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Attachment #51264|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 05 May '16

05 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51234|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 51264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51264&action=ed… [PASSED QA] Bug 16386 - Replace the use of "onclick" from patron card creator templates This patch removes the use of "onclick" from several patron card creator templates. Events are defined instead in JavaScript. Also changed: - Patron search pop-up window is now slightly larger because I found it never quite large enough to prevent horizontal scrolling. - Replaced "Borrower" with "Patron" in a couple of places. - "Add" link in patron search pop-up is now styled as a Bootstrap button. - Removed Bootstrap styles from some submit buttons. - Some Font Awesome icons were made using the invalid element <icon></icon> instead of <i></i>. These are corrected. - Fixed some other HTML validation errors. To test, apply the patch and go to Tools -> Patron card creator. - Choose New -> Card batch. - Click "Add patrons" and perform a search for patrons in the pop-up window. - Click the "Add" button. The corresponding borrowernumber should be added to the textarea in the parent window, and a message should appear at the top of the pop-up window confirming that the patron has been added. (Note: This patch fixes a version of Bug 13041 which prevented the "add" button from working on patrons whose name include an apostrophe). - In the parent page, in the list of patrons you added to the batch, confirm that clicking the "Delete" link triggers a confirmation dialog. Test both confirming and canceling. - Confirm that clicking the "Export" button next to an individual patron triggers a modal window. - In the export window, confirm that the "Cancel" link works to close the modal. - Click the "Export" button again and then the "Export" button in the modal. - Test that the "Done" button works to close the modal. - Choose Manage -> Card batches. - Test the "Delete" and "Export" buttons as described above. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> All works, no errors. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 05 May '16

05 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16438] New: Use Font Awesome icons in batch record deletion table
by bugzilla-daemon＠bugs.koha-community.org 05 May '16

05 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Bug ID: 16438 Summary: Use Font Awesome icons in batch record deletion table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx(a)gmail.com Reporter: hector.hecaxmmx(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Add Font Awesome icons in table for tables in authorities and bib records in batch record deletion -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 14005] Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder
by bugzilla-daemon＠bugs.koha-community.org 05 May '16

05 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0