May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 --- Comment #1 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51126&action=ed… Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record With the global %default_values_for_mod_from_marc variable, the changes made to the marc_subfield_structure table and especially the links between MARC and DB fields are not safe and might be outdated (if a field is linked/unlinked) Test plan: Under Plack: - Link the barcode field, edit a record and set a barcode. - Remove the mapping for the barcode field and then update again the barcode of the record. The items.barcode DB field must not have been updated. Without this patch, the field should have been updated. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #85 from Florent Mara <florent.mara(a)gmail.com> --- I agree 100% Katrin. Being merge master at work, I know the pain and have debated the options several times. It was already a bit patch when I found it, only made it bigger ... Overall, I doubt more than 30 lines of 'working' code has been added so far. Most of my contributions are tests + bug fixes. ~95% of my refactoring is taking chunks of existing code from the main script and putting it in methods. Then adding pedantic tests to validate equivalence of output. The other 5% are defect fixes. I thought of stopping last week then found a defect so kept going (I intended to create a specific bug report for the dates defect but ran out of time today). Then a second - minor - defect while at it today. Ultimately, none of my work is intended to change code behavior - unless defect. This refactoring + tests work is in preparation for my task of improving the importer performance which is hardly possible while working on a 300 lines untested script. For test plan, I use the 1000 entries file from the importer performance bug, would it be worth giving more details here? I loaded plenty of patrons today, it would be good for someone else to give it a try and update the status. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12874] On editing an item, some fields can be set to NULL
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12874 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 [Bug 16428] The framework is not checked to know if a field is mapped -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 [Bug 16428] The framework is not checked to know if a field is mapped -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15840] New: Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Bug ID: 15840 Summary: Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org to replicate the bug 1/ import a borrowers.csv file containing any row with a blank 'userid' value, - use the 'overwrite' option. 2/ repeat step 1/ koha dies with error.. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '' for key 'userid' at /path/to/yr/koha/C4/Members.pm line 683 bug confirmed on 3.18.9 -> master 43bcc1c -- You are receiving this mail because: You are watching all bug changes.

1 38

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #84 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Florent, please be careful not to let this grow too big on a single bug report, might be got so split issues out into several bugs at some point :) We will also need a test plan for the testers. Is the status correct? (Patch doesn't apply) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #83 from Florent Mara <florent.mara(a)gmail.com> --- The latest patch includes the following: (1) Further refactoring and regression tests in Koha::Patrons::Import module. (2) A minor bug fix for header row parser by which it was possible to fail the header row parsing (status equal to 0) yet call on Text::CSV->field() which would create an undef entry in both the @csvcolumns and %csvkeycol variables. (3) A more important bug fix related to dateofbirth, dateenrolled and dateexpiry imports by which the failure to format the dates would see these being silently ignored/replaced with default dates. This defect was caused by the @missing_criticals being populated but ignored in the remainder of the loop. This defect is still present in master. -- You are receiving this mail because: You are watching all bug changes.

1 0