May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51599|0 |1 is obsolete| | --- Comment #16 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 51601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51601&action=ed… Bug 13669: (followup) Fix kohastructure.sql so FK dependencies are sorted The current table creation order is left to mysql's strategy, which is not suitable for parsing the SQL files and passing one statement at a time in the current order. This patch just moves table creation statements around so FK constraints are defined for previously created tables. Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51598|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 51600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51600&action=ed… Bug 13669: Use perl to load SQL statements from sample data This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read the SQL files, and SQL::SplitStatement to extract the statements from the full SQL file so they can be passed to $dbh->do. To test: - On Mysql 5.5, run the webinstaller => SUCCESS: Everything works as expected - Apply the patch - Run $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => SUCCESS: Everything works as expected - On Mysql 5.6+ (5.7 is implied) - Run $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => FAIL: It cannot load the sql files due to a password-in-command-line error - Apply the patch - Make sure everything is clean (it should): $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => SUCCESS: EVerything works as expected - Sign off :-D [1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty problem but using File::Slurp to load the SQL files in memory comes with a big runtime penalty. You will notice the install procedure is now much slower, for instance. Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #14 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 51599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51599&action=ed… Bug 13669: (followup) Fix kohastructure.sql so FK dependencies are sorted The current table creation order is left to mysql's strategy, which is not suitable for parsing the SQL files and passing one statement at a time in the current order. This patch just moves table creation statements around so FK constraints are defined for previously created tables. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51597|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 51598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51598&action=ed… Bug 13669: Use perl to load SQL statements from sample data This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read the SQL files, and SQL::SplitStatement to extract the statements from the full SQL file so they can be passed to $dbh->do. To test: - On Mysql 5.5, run the webinstaller => SUCCESS: Everything works as expected - Apply the patch - Run $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => SUCCESS: Everything works as expected - On Mysql 5.6+ (5.7 is implied) - Run $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => FAIL: It cannot load the sql files due to a password-in-command-line error - Apply the patch - Make sure everything is clean (it should): $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => SUCCESS: EVerything works as expected - Sign off :-D [1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty problem but using File::Slurp to load the SQL files in memory comes with a big runtime penalty. You will notice the install procedure is now much slower, for instance. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 --- Comment #10 from Barton Chittenden <barton(a)bywatersolutions.com> --- t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 11/42 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 42 Failed: 11) Failed tests: 22, 24-28, 32-34, 36, 40 Non-zero exit status: 11 Files=1, Tests=42, 3 wallclock secs ( 0.03 usr 0.00 sys + 2.02 cusr 0.12 csys = 2.17 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51596|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 51597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51597&action=ed… Bug 13669: Use perl to load SQL statements from sample data This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read the SQL files, and SQL::SplitStatement to extract the statements from the full SQL file so they can be passed to $dbh->do. To test: - On Mysql 5.5, run the webinstaller => SUCCESS: Everything works as expected - Apply the patch - Run $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => SUCCESS: Everything works as expected - On Mysql 5.6+ (5.7 is implied) - Run $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => FAIL: It cannot load the sql files due to a password-in-command-line error - Apply the patch - Make sure everything is clean (it should): $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => SUCCESS: EVerything works as expected - Sign off :-D [1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty problem but using File::Slurp to load the SQL files in memory comes with a big runtime penalty. You will notice the install procedure is now much slower, for instance. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #11 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 51596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51596&action=ed… Bug 13669: Use perl to load SQL statements from sample data This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read the SQL files, and SQL::SplitStatement to extract the statements from the full SQL file so they can be passed to $dbh->do. To test: - On Mysql 5.5, run the webinstaller => SUCCESS: Everything works as expected - Apply the patch - Run $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => SUCCESS: Everything works as expected - On Mysql 5.6+ (5.7 is implied) - Run $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => FAIL: It cannot load the sql files due to a password-in-command-line error - Apply the patch - Make sure everything is clean (it should): $ mysql -uroot > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev; - Run the webinstaller => SUCCESS: EVerything works as expected - Sign off :-D [1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty problem but using File::Slurp to load the SQL files in memory comes with a big runtime penalty. You will notice the install procedure is now much slower, for instance. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other
by bugzilla-daemon＠bugs.koha-community.org 18 May '16

18 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49089|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 51595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51595&action=ed… Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other It appears that the LocalHoldsPriority feature and the Holds Queue are fundamentally at odds with each other. The problem appears to be that both are attempting to choose the best way to fill holds. When you are using the holds queue and you check in an item that has been selected by the holds queue builder, that part of Koha where the LocalHoldsPriority feature lives doesn't get to see all the holds in order to pick the best one. Instead only the hold selected by the holds queue builder is returned so to the LocalHoldsPriority feature, that is only one hold to pick from! Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t 3) All tests should pass -- You are receiving this mail because: You are watching all bug changes.

1 0