May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13211] Added: GoogleIndicTransliteration as a System Preference
by bugzilla-daemon＠bugs.koha-community.org 15 May '16

15 May '16

1 0

[Bug 10095] There should be a way to suppress a category of authorised values
by bugzilla-daemon＠bugs.koha-community.org 14 May '16

14 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10095 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 14 May '16

14 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #106 from Florent Mara <florent.mara(a)gmail.com> --- (Thank you Bernardo for the advice on trying to progress this) Here are the changes introduces in each of the 6 patches: Patch 1 - Replace deprecated C4::Dates with Koha::DateUtils and backport fix from master for entries with empty userids. This fix is deprecated in my last commit due to bug 16426. Patch 2 - Add missing dependency C4::Members::Attributes and some pod. Add the first regression tests - none were present previously - with basic tests for empty parameters variables and valid input file. Patch 3 - Introduced Moo. Refactored setting of column keys, missing borrower category code and missing borrower branch code into 3 new methods. Features are identical as prior. Each method is 100% test covered with subtests. Patch 4 - Update misc/import_patrons.pl and tools/import_borrowers.pl to use Koha::Patrons::Import in an object oriented way. Patch 5 - Adds missing dependency C4::Members::AttributeTypes. Refactor setting attributes types, prepare columns and dates formatting into 3 new methods. Features for attributes type and prepare column are identical. Date formatting was changes as follows after discussion with Chris. * The previous implementation let parsing of dates silently failed then be overwritten with system default values during import as the error was push to @missing_criticals after this array was last considered. * The new implementation formats dates and uses @missing_criticals before it is used to bail out of importing the entry. Each new method is 100% test covered with subtests. Patch 6 - Backport changes from bug 16426 and fixes the defect it introduces. As per my comment in 16426, the fix was introduced at the wrong place in the code which caused it to never be reached and prevents checks on duplicate userid . Test plan: 1) Apply this patch. 2) Set dateformat to mm/dd/yyyy. (Koha home->Administration->search for dateformat -> select and save) 3) run 'prove t/db_dependent/Koha/Patrons/Import.t'. All 122 tests should pass. These regression tests validate (1) Koha::Patrons::Import compiles, (2) all fields output from the main import() method are identical before and after refactoring (equivalence of output), (3) all 6 new methods provide the expected feature, (4) backport duplicate userid fix. 4) Run the online importer ( Koha home->tools->Import patrons) Load PatronDataCSV1.csv sample file with default import parameters. It should result in 165 imported records and 835 not imported because they are not in the expected format. This step validates that (1) tools/import_borrowers.pl works as previously and wrongly formatted dates are now correctly being reported as such. 5) Set dateformat to dd/mm/yyyy. 6) Run the new command line importer 'perl misc/import_patrons.pl -f PatronDataCSV1.csv -c -m 'cardnumber' -v' It should load the remaining 835 entries from the sample file. Import complete: Imported: 835 Overwritten: 0 Skipped: 0 Invalid: 165 Total: 1000 This step validates the new command line tool misc/import_patrons works and confirm date validation is effective. While this is a big patch, it contains only one feature change to fix dates being silently overwritten and is coming with a large number of tests with extensive test coverage for all changes made. It also contains a regression tested fix for bug 16426. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1859] Notice fields: can't select multiple fields at once
by bugzilla-daemon＠bugs.koha-community.org 13 May '16

13 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51490&action=ed… Bug 1859: Do not display <<>> if an entry without value is selected For instance there are ---TABLES--- to delimite fields' tables, if selected we do not want to add "<<>>" to the letter. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1859] Notice fields: can't select multiple fields at once
by bugzilla-daemon＠bugs.koha-community.org 13 May '16

13 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51465|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51489&action=ed… Bug 1859 - Notice fields: can't select multiple fields at once When selecting database fields to appear in a notice, selecting multiple fields at once doesn't work correctly. The selected fields are grouped together between << and >> instead of each being bracketed separately. This patch corrects this problem. Also changed: Removal of 'onclick'; Conversion of 'insert' button to a Bootstrap buttons styled with a Font Awesome icon; HTML validation error fixes. To test, apply the patch and go to Tools -> Notices & Slips. - Edit any notice. - Select a notice version to edit (Email, Print, etc.). - Confirm that the "Insert" button looks correct. - Using ctrl+click, select multiple database fields to add to the notice. Confirm that clicking the "Insert" button adds the fields correctly. - Confirm that there are no HTML validation errors. Signed-off-by: Nicole C Engard <nengard(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1859] Notice fields: can't select multiple fields at once
by bugzilla-daemon＠bugs.koha-community.org 13 May '16

13 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12402] Show more on pending patron modification requests
by bugzilla-daemon＠bugs.koha-community.org 13 May '16

13 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51455|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51488&action=ed… Bug 12402: Show patron category on pending patron modifications To test: 1) Go to OPAC and make a modification to user 2) Go to Staff Client and go to pending patron modifications 3) Notice that we have the user's surname, first name, branch and cardnumber 4) Apply patch and refresh page 5) Notice that patron category now shows after user's name Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12402] Show more on pending patron modification requests
by bugzilla-daemon＠bugs.koha-community.org 13 May '16

13 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other
by bugzilla-daemon＠bugs.koha-community.org 13 May '16

13 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Barton Chittenden <barton(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |barton(a)bywatersolutions.com --- Comment #8 from Barton Chittenden <barton(a)bywatersolutions.com> --- Patch does not apply. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15086] Creators layout and template sql has warnings
by bugzilla-daemon＠bugs.koha-community.org 13 May '16

13 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51444|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51486&action=ed… Bug 15086: Creators layout and template sql has warnings When doing a hacked install off the master branch: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. Most of the warnings were triggered by: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_… In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_war… Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. See comment #1 for the test plan. NOTE: pl-PL is likely very out of date, but is not affected in this regard. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Works, no more warnings mysql> show warnings; Empty set (0.01 sec) No errors Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0