June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14797] Cancelling orders with no alert to existing holds
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797 --- Comment #1 from Owen Leonard <oleonard(a)myacpl.org> --- Here's what I found in master: - After the hold is placed, the view of items in the basket shows that I can't cancel the hold and delete the record, but doesn't show a reason. I think it should warn me about the holds. - The cancel order link is active, and lets me cancel the order without warning me of any holds. - After canceling the order the hold remains on the record, but I am not prevented from canceling the hold from the holds screen. The current status of this bug isn't as serious as it sounds like it is in 3.18.x, but the issue of warning about existing holds still exists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #29) > Small glitch with and without patch: if you don't enter a message it takes a > while for the page to load, but there is no message saved. I don't notice that (under plack). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #32 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52642&action=ed… Bug 3669: Remove parameters passed to action of form Sounds weird to pass parameters to the action of a POST form. This patch adds a workaround. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51374|0 |1 is obsolete| | Attachment #52277|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52641&action=ed… Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar This patch moves all the code into an include which can be accessed from the 'Add a new message' link or the patron toolbar. EDIT: Ensuring modal opens on all pages EDIT2: Once the form has been submitted the page will redirect to where you submitted the form from. EDIT3: Fixing indentation of member-add-message.inc Ensuring messages save on every page Fill branch Ensure predefined notes appear Form redirects to where it was submitted from, or just the circulation page. EDIT4: Removing the new include file and moving it all into the modal in the toolbar EDIT5: Removing swp file and unnecessary code duplication by utilising plugins EDIT6: Batch checkout fixes EDIT7: Ensure you do not get JS error from Comment 24 (Batch checkout syspref must be turned on) To test: 1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X) 2) Click 'Add a new message' under Messages 3) Confirm this brings up the modal to add a message. Confirm clicking Save saves your message. If it is an OPAC message (for the user), confirm it shows as expected on the OPAC. 4) Click Cancel. Confirm this closes the modal. 5) Click 'Add message' button in toolbar. Complete steps 3 and 4. 6) Confirm the modal opens from all other pages with the members toolbar. Confirm predefined notes shows. circ/circulation.pl members/moremember.pl members/routing-lists.pl members/statistics.pl members/boraccount.pl members/pay.pl members/maninvoice.pl members/mancredit.pl members/readingrec.pl members/notices.pl members/member-flags.pl members/member-password.pl members/paycollect.pl members/files.pl turn on BatchCheckouts syspref and put in appropriate patron category circ/circulation.pl?borrowernumber=X&batch=1 7) Confirm that the page redirects to where you submitted the form from once you have submitted it. 8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you saved it) Sponsored-by: Catalyst IT Followed test plan, works as expected. (Re-tested for comment #24) Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14434] OPAC should indicate to patrons that auto renewal will not work because hold has been placed
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #11) > But also a question: Would it be possible to reload the page? I accidentally > ended up with 2 claims, where I was not sure it had worked before. I think > this could be a trap a lot of libraries fall into. It should be possible yes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16713] New: Unknown Error Message from Item records
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16713 Bug ID: 16713 Summary: Unknown Error Message from Item records Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: lauraerinmann(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Hi, I'm running Koha 3.18.12.000 and I can this error when I try to update items for a record: :21: parser error : Opening and ending tag mismatch: record line 6 and datafield </datafield> ^ :22: parser error : Opening and ending tag mismatch: collection line 2 and record </record> ^ :23: parser error : Extra content at the end of the document </collection> the url pattern is something like this: ../cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=''&itemnumber=''#edititem When I edit one of the fields on this screen it throughs the error above. It seems like a xml error, but after some internet sleuthing I came up with nothing. I also posted to the boarded and waited at least a month for a response and found nothing. The error message doesn't tell me much about wha the error is. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #315 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Taking the liberty to set this back to PQA. String patches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52639&action=ed… Bug 12178: Fix tests not to depend on dateformat syspref -- You are receiving this mail because: You are watching all bug changes.

1 0