June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14752] Add multiple copies to a basket at once
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #26 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- I have tried to install it on a sandbox : Some problems occurred applying patches from bug 14752: <h1>Something went wrong !</h1>Applying: Bug 14752 - Add multiple copies to a basket at once Applying: Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Barcodes/hbyymmincr.pm CONFLICT (content): Merge conflict in C4/Barcodes/hbyymmincr.pm Failed to merge in the changes. Patch failed at 0001 Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 14752 - Add multiple copies to a basket at once 51481 - Bug 14752 - Add multiple copies to a basket at once 52083 - Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead Sonia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- sorry wrong bug... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)univ-lyon3.fr Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- I have tried to install it on a sandbox : Some problems occurred applying patches from bug 14752: <h1>Something went wrong !</h1>Applying: Bug 14752 - Add multiple copies to a basket at once Applying: Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Barcodes/hbyymmincr.pm CONFLICT (content): Merge conflict in C4/Barcodes/hbyymmincr.pm Failed to merge in the changes. Patch failed at 0001 Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 14752 - Add multiple copies to a basket at once 51481 - Bug 14752 - Add multiple copies to a basket at once 52083 - Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead Sonia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #46 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Katrin Fischer from comment #42) > The mandatory fields show up nicely, but I have problems using the new > PatronQuickAddFields for adding additional fields. The fields are not > showing up. I got my equalities mixed up, fixed! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52192|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52586&action=ed… Bug 3534 (QA Followup) Fix indentation, show guarantor form, ignore bad data in pref Switch incorrect == to != when checking skipped fields -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51961|0 |1 is obsolete| | --- Comment #44 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52585&action=ed… Bug 3534 - QA Followup - use floating save I am not sure if this is desired, it makes sense for consistency but floats in a wierd place for a short form. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51960|0 |1 is obsolete| | --- Comment #43 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52584&action=ed… Bug 3534 - Patron quick add form This patch adds a new system preference: PatronQuickAddFields When either this pref or BorrowerMandatoryField is populated this will add a new dropdown to the bew patron toolbar. When a category is chosen from this dropdown the fields in PatronQuickAddFields and BorrowerMandatoryField will be displayed. There will be a button allowing a user to switch from the quickadd to the full form and fields will be copied between the forms when toggling. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields and note the new button for adding a patron 5 - Click the Quick add and choose a type 6 - Only required or quick add fields should be displayed 7 - Verify toggling forms copies information 8 - Ensure you cannot save patron without filling required fields (quick add fields should be optional) 9 - Ensure you can save patron with fields filled out 10 - Ensure that a duplicate patron brings up the duplicate/add new buttons with full form displayed 11 - Verify that subsequent edits use only full form 12 - Verify that data on form submitted is the data saved to patron 13 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) Followed test plan, works as expected. Re-tested together with followup, works as expected (2016-06-02) Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14822] Fine totals on circulation.pl don't include manually added fees
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14822 --- Comment #2 from Barton Chittenden <barton(a)bywatersolutions.com> --- (In reply to Liz Rea from comment #1) > Why not include them? Yes, I suppose that would work too :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '16

20 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 --- Comment #4 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 52579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52579&action=ed… Bug 14868: Use x-koha-permission in current routes Adds missing permission checking to holds. Adds 6 tests to patrons.t, adds 30 tests to holds.t. -- You are receiving this mail because: You are watching all bug changes.

1 0