June 2016 - Koha-bugs - lists.koha-community.org

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52014|0 |1 is obsolete| | --- Comment #43 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 52035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52035&action=ed… Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList C4::Members::GetBorrowercategoryList returned all the patron categories, ordered by description. This can be done using the search method of the Koha::Patron::Categories module. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by description. - On the "patron attribute types" admin page (admin/patron-attr-types.pl). - On the "Batch patron deletion/anonymization" (tools/cleanborrowers.pl), the dropdown list should be filled correctly. - On the import patron tool - On the following report: reports/reserves_stats.pl Confirm that the patron categories are displayed and that the report still works as before. Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7223] Move borrowerRelationship to Authorised Values list
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7223 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain(a)biblibre.com |koha-bugs(a)lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 5732] Adding permissions on viewlog
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5732 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain(a)biblibre.com |koha-bugs(a)lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7972] GUI for Crons
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain(a)biblibre.com |koha-bugs(a)lists.koha-commun | |ity.org --- Comment #1 from Paul Poulain <paul.poulain(a)biblibre.com> --- Removing assignment to me -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52013|0 |1 is obsolete| | --- Comment #42 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 52034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52034&action=ed… Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory The purpose of C4::Members::GetBorrowercategory was to return the patron category for a given categorycode. This can be done easily with the Koha::Patron::Categories->find method. Test plan: - Same prerequisite as before - Edit a guarantor and confirm the information will be updated for his/her guarantee(s). - Update a child to adult patron (Note: Should not we hide the patron categories limited to others libraries? If yes, it must be done on another bug report). There is a special behavior if there is only 1 adult category, the user does not need to select a category. So the same as before with only 1 adult patron category. - Import a patron with a category_code which does not exist. You should be warned. - Modify some patron using the batch patron modification tool. The patron category descriptions should correctly be displayed. Note that the overduerules page has already been tested in a previous patch. Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50171|0 |1 is obsolete| | --- Comment #41 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 52033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52033&action=ed… Bug 15407: Koha::Patron::Categories - replace C4::Category->all The C4::Category module contained only 1 method to return the patron categories available for the logged in user. The new method Koha::Patron::Categories->search_limited does exactly the same thing (see tests) and must be used in place of it. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. - On the 'Item circulation alerts' admin page (admin/item_circulation_alerts.pl), modify the settings for check-in and checkout (NOTE: Should not we display all patron categories on this page? If yes, it must be done in another bug report to ease backporting it). - Search for patrons in the admin (budget) and acquisition (order) module. - On the patron home page (search form in the header) Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4944] Create separate noItemTypeImages preferences for OPAC and staff client
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain(a)biblibre.com |koha-bugs(a)lists.koha-commun | |ity.org --- Comment #3 from Paul Poulain <paul.poulain(a)biblibre.com> --- Removing assignment to me -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug.

1 0

[Bug 5598] More Granular Cloning Circulation & Fine Rules
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5598 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain(a)biblibre.com |koha-bugs(a)lists.koha-commun | |ity.org --- Comment #1 from Paul Poulain <paul.poulain(a)biblibre.com> --- Still valid in 16.05, removing assignment to me -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50170|0 |1 is obsolete| | --- Comment #40 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 52032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52032&action=ed… Bug 15407: Koha::Patron::Categories - remove sql queries in some pl and pm This patch replaces sql queries done in some pl script and in C4::Reports::Guided. Since we have now a Koha::Patron::Categories module, we should use it where it is possible. Test plan: - Prerequisite: Be sure you have several patron categories created, with different option enabled, and limit some to certain libraries. - On the 'Circulation and fine rules' admin page (admin/smart-rules.pl), all the patron categories should be displayed (even the ones limited to another library), ordered by description. Try to add/update existing rules. - On the overdue rules page (tools/overduerules.pl), all the patron categories with overduenoticerequired set should be displayed. Try to add/update existing rules. - On the following reports: reports/borrowers_stats.pl reports/issues_avg_stats.pl The patron categories should be displayed. Note that there is an inconsistency with these 2 reports: the patron categories limited to other libraries are displayed on them, when they are not on the other reports. This should certainly be fixed (on another bug report). Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7374] can't upload icon for auth values
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain(a)biblibre.com |koha-bugs(a)lists.koha-commun | |ity.org --- Comment #3 from Paul Poulain <paul.poulain(a)biblibre.com> --- still valid, removing assignment to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0