July 2016 - Koha-bugs - lists.koha-community.org

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #67 from Bouzid <bouzid.fergani(a)inlibro.com> --- Created attachment 53572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53572&action=ed… Bug 6934: New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #66 from Bouzid <bouzid.fergani(a)inlibro.com> --- Created attachment 53571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53571&action=ed… Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #65 from Bouzid <bouzid.fergani(a)inlibro.com> --- Created attachment 53570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53570&action=ed… Bug 6934 New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home › Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole <nicole(a)bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 16889] New: Move the ::columns subroutines to Koha::Objects->columns
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 Bug ID: 16889 Summary: Move the ::columns subroutines to Koha::Objects->columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Currently we have 3 subroutines to retrieve the columns of tables: C4::Members::columns, C4::Items::columns and C4::Items::biblioitems_columns. It will be easier to have a Koha::Objects->columns method to provide the different classes to retrieve their related column names. -- You are receiving this mail because: You are watching all bug changes.

1 28

[Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Liz Rea from comment #20) > I think I see what I did wrong now - I was testing this in the staff client! > How very silly of me. Will give it one more go today, you know, doing it > properly. :) Thx Liz for your signoff. Should have mentioned opac in the latest commit message.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #22 from Liz Rea <liz(a)catalyst.net.nz> --- Created attachment 53547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53547&action=ed… Bug 15545: Use IsHoldNoteRequired in opac-reserve.pl This patch implements use of the new Reserves routine IsHoldNoteRequired, making it possible to require a note when placing a hold. Only a very small change in opac-reserve.pl is needed. As well as corresponding changes in the template. I am removing some unused template code related to a former approach. Test plan: [1] Disable UseKohaPlugins, enable OpacHoldNotes. [2] Place a hold on a serial record (leader pos 7 == s). Verify that the hold note is not required. [3] Enable UseKohaPlugins. Install the Rijks_HoldNoteRequired plugins. (Go to plugins/plugins-home.pl and upload Rijks_HoldNoteRequired.kpz. This file can be found as an attachment to this BZ report.) [4] Again place a hold on a serial record. The hold note should be required. Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51833|0 |1 is obsolete| | --- Comment #21 from Liz Rea <liz(a)catalyst.net.nz> --- Created attachment 53546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53546&action=ed… Bug 15545: Add routine IsHoldNoteRequired to Reserves module This routine will be used to determine if a hold note is required. In the current approach this is implemented by use of Koha plugins. A former approach included a syspref. This is no longer needed. This approach is even more flexible. The routine will use all plugins it finds with metadata tag 'implements' set to 'IsHoldNoteRequired'. If one of these plugins has a check method that returns true, the hold note should be regarded as required. The plugins Rijks_HoldNoteRequired_Extent and _Leader offer an implementation where the value of the leader or MARC21 300$a determines if the hold note is required. Similarly, any other field of the bibliographic record could be used in a new plugin. Test plan: Run unit test t/db_dependent/Reserves/IsHoldNoteRequired.t. Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15824] New: 'Done' button is unclear on batch item modification and deletion
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Bug ID: 15824 Summary: 'Done' button is unclear on batch item modification and deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org To reproduce, go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) Click edit -> Edit items in a batch Click Save (you don't need to make any changes) Notice Done link at the bottom of the page is not very noticeable. This is the same with batch item deletion as well. -- You are receiving this mail because: You are watching all bug changes.

1 25