July 2016 - Koha-bugs - lists.koha-community.org

[Bug 11976] show issue date instead of received date for serials in opac
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Caroline <caroline.stone(a)wiltshire.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.stone(a)wiltshire.ac | |.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #12 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- tested with several days closed on the library. It works as described for the calculation of expirationdate with ExcludeHolidaysFromMaxPickUpDelay activated/desactivated and ReservesMaxPickUpDelay=5. Cancelation with cancelation with misc/cronjobs/holds/cancel_expired_holds.pl (launched on the server by biblibre staff) works normaly. I tried to activate/desactivate the syspref ExpireReservesOnHolidays : if it was on "don't allow" and today was closed on the calendar, holds expired are not cancelled. If it was on "allow", holds are cancelled. Fees are applied if something is set in ExpireReservesMaxPickUpDelayCharge syspref. So works as expected :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #11 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 53101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53101&action=ed… Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database Signed-off-by: sonia BOUIS <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #10 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 53100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53100&action=ed… Bug 12063: Change date calculation for reserve expiration to skip all holiday This patch makes koha automatically set expiration date when reserves become waitting. Also it adds a new syspref "ExcludeHolidaysFromMaxPickUpDelay" that allows to take holidays into account while calculating expiration date. Test plan: - Install this patch and run updatedatabase.pl script, - allow ExpireReservesMaxPickUpDelay in system preferences, - set ReservesMaxPickUpDelay to 5. - Place an hold on a checked out item and check in this item: The hold's expiration date should be today + 5. - Allow ExcludeHolidaysFromMaxPickUpDelay in system preferences, - add holiday during this pickup delay period, - Create a new hold and make it comes waitting: The hold's expiration date should be today + 5 + number of closed day(s). Also: - Check that ExpireReservesOnHolidays syspref works again without ExcludeHolidaysFromMaxPickUpDelay. - Check that cancel fees apply again if wanted. Signed-off-by: sonia BOUIS <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52949|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes(a)biblibre.com Status|Needs Signoff |Signed Off --- Comment #9 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by sonia BOUIS <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #52 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #51) > (In reply to Colin Campbell from comment #49) > > Comment on attachment 53013 [details] [review] [review] > > Bug 15006: Add timeout and strikes to raw_transport > > > > This is unnecessary - The bogus 3 strikes was already removed in commit > > 078ce11e113b172726f9ab3180e52a06334d4aab > > > > > > Test plan is ambiguous this routine is not called when using "telnet" > > authentication. On a raw connection session is started when a sip login is > > received. If that login fails, the session is terminated. (The login is from > > the client machine's config so it wont try again with different values) and > > sends a failed login response before shutting down. If the input is not a > > login message or a random string it does not respond or login the session > > but falls through to sip_protocol_loop and times out on the time out set > > there. I think this should be considered a bug. Its probably the reason why > > adding a timeout to that had an effect on building up sip sessions as that > > is meant to be an endless (until logout or connection drop) loop - I think > > this a bug and that if a connection is not established raw_transport should > > exit without entering sip_loop > > From testing i recall seeing that raw_transport does respond to requests; > one of the reasons that I made it more restrict in a previous patch (relaxed > it later again for minimal behavior changes). Been doing some extensive testing and the raw_transport routine going some things very differently than I think we all imagine. Will post the patch when final element merged. We need the timeout to escape the while if anyone can engineer us into an infinite loop there (I've not been able to do that ...but..) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15088] Notice when koha has been installed with --request-db instead of --create-db
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16690 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15088] Notice when koha has been installed with --request-db instead of --create-db
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 --- Comment #13 from Liz Rea <liz(a)catalyst.net.nz> --- Hi, Yes, that is what we're doing. When you put it that way, it seems crazy. However, crazy as it sounds, my thinking was that there might eventually be other things that we wanted to keep track of in a centralised location. I see it as the first instance of having a method of making a Koha self-documenting. A way to make sure we can know how a koha was originally installed, a way to ease troubleshooting for admins, a way to provide explicit error messages for specific types of installations. As Koha installations pass from admin to admin, knowledge is lost. When the knowledge is lost, libraries leave Koha. This desire of mine may not be enough to encourage acceptance of this patch. That's fine. I just wanted to make sure you knew where my head and heart were at when I submitted this in this way. Liz -- You are receiving this mail because: You are watching all bug changes.

1 0