July 2016 - Koha-bugs - lists.koha-community.org

[Bug 7172] Omnibus for Plack variable scoping problems
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Galen Charlton <gmcharlt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16760 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 [Bug 16760] Circulation Statistics wizard not populating itemtype correctly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #51 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Hi Kyle, I've added 2 more patches to resolve the issues you raised. - One patch now adds updated schema files for dbic. This will fix the test error (previously I assumed the tester would do this, but since the last hackfest I no longer make that assumption). - The other patch renames the methods as requested. Hopefully this addresses the final issues for this bug? Thanks for the review! Alex -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #50 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 53105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53105&action=ed… Bug 6906: Add updated schema files. * Koha/Schema/Result/Borrower.pm: Updated schema file. * Koha/Schema/Result/Category.pm: Updated schema file. * Koha/Schema/Result/Deletedborrower.pm: Updated schema file. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #49 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 53104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53104&action=ed… Bug 6906: Follow coding guidelines in terminology. * Koha/Patron.pm (wantsCheckPrevCheckout, doCheckPrevCheckout): Rename to... (wants_check_for_previous_checkout, do_check_for_previous_checkout): ...this. * C4/Circulation.pm: Use new names. * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 11976] show issue date instead of received date for serials in opac
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Caroline <caroline.stone(a)wiltshire.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.stone(a)wiltshire.ac | |.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #12 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- tested with several days closed on the library. It works as described for the calculation of expirationdate with ExcludeHolidaysFromMaxPickUpDelay activated/desactivated and ReservesMaxPickUpDelay=5. Cancelation with cancelation with misc/cronjobs/holds/cancel_expired_holds.pl (launched on the server by biblibre staff) works normaly. I tried to activate/desactivate the syspref ExpireReservesOnHolidays : if it was on "don't allow" and today was closed on the calendar, holds expired are not cancelled. If it was on "allow", holds are cancelled. Fees are applied if something is set in ExpireReservesMaxPickUpDelayCharge syspref. So works as expected :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #11 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 53101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53101&action=ed… Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database Signed-off-by: sonia BOUIS <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #10 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 53100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53100&action=ed… Bug 12063: Change date calculation for reserve expiration to skip all holiday This patch makes koha automatically set expiration date when reserves become waitting. Also it adds a new syspref "ExcludeHolidaysFromMaxPickUpDelay" that allows to take holidays into account while calculating expiration date. Test plan: - Install this patch and run updatedatabase.pl script, - allow ExpireReservesMaxPickUpDelay in system preferences, - set ReservesMaxPickUpDelay to 5. - Place an hold on a checked out item and check in this item: The hold's expiration date should be today + 5. - Allow ExcludeHolidaysFromMaxPickUpDelay in system preferences, - add holiday during this pickup delay period, - Create a new hold and make it comes waitting: The hold's expiration date should be today + 5 + number of closed day(s). Also: - Check that ExpireReservesOnHolidays syspref works again without ExcludeHolidaysFromMaxPickUpDelay. - Check that cancel fees apply again if wanted. Signed-off-by: sonia BOUIS <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52949|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0