July 2016 - Koha-bugs - lists.koha-community.org

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15561] Add ability to charge cancelation fee from "Holds over" tab
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Kyle, can you please add an atomicupdate for the syspref renaming? Also 2 more tiny thing: - correct alphabetic sorting in syspref.sql - Sypref description has "if a waiting hold cancellation fee is to be charged" instead of cancelation with one l (consistency! :) ) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 53736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53736&action=ed… [PASSED QA] Bug 15023: (followup) Remove warnings By setting 'use Modern::Perl' some previously hidden warnings arised. This patch removes them by testing the variable $balance for undef before using it in a comparisson. Sponsored-by: VOKAL Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53463|0 |1 is obsolete| | Attachment #53464|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 53735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53735&action=ed… [PASSED QA] Bug 15023: Allow patron anonymize/bulk delete tool to be limited by branch This patch makes the bulk patron delete/anonymize functionality be limited by branch. It does so by adding a branch selection dropdown and using the already defined APIs for filtering by branch. It makes use of C4::Branches::onlymine for the IndependentBranches use case and it adds a way to call it from the Branches template plugin. To test: - Apply the patch 1) Have a superlibrarian user - Go to Tools > Batch patron deletion/anonymization => SUCCESS: Verify you can pick a branch (or all of them) - Try doing some operations => SUCCESS: Verify the selection is respected, and carried around all steps 2) Have a user with tools/delete_anonymize_patrons permissions - Set IndependentBranches on - Go to Tools > Batch patron deletion/anonymization => SUCCESS: It picks the librarian's branch and doesn't let us choose another one - Try doing some operations => SUCCESS: Verify the user's branch is respected, and carried around all steps - Sign off :-D Sponsored-by: VOKAL Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- We found out: while deleting patrons works by the patron's homebranch, anonymizing uses the checkout branch. As this is the existing behaviour with independent branches turned on, the new behaviour is consistent. Maybe this could be added as a note to documentation. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14642] Add logging of hold modifications
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 --- Comment #19 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 53734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53734&action=ed… Bug 14642: (QA followup) Make HoldsLog default to 0 After a couple comments regarding the default value I picked for the new syspref, I've decided to set it 0, as libraries interested on the fetarue will just enable it. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14642] Add logging of hold modifications
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 --- Comment #18 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- I'm not sure why the patch that introduces the syspref got obsoleted! Reverting it -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14642] Add logging of hold modifications
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52824|1 |0 is obsolete| | --- Comment #17 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Comment on attachment 52824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52824 Bug 14642: Add HoldsLog syspref >From 133621157e8fe90cd4728970c23a4869d3212f43 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen(a)theke.io> >Date: Fri, 24 Jun 2016 11:34:01 -0300 >Subject: [PATCH] Bug 14642: Add HoldsLog syspref > >This patch introduces a new syspref 'HoldsLog' which is to be used for controlling >holds actions logs. > >Sponsored-by: NEKLS >--- > .../data/mysql/atomicupdate/bug_14642_holds_logging.sql | 13 +++++++++++++ > installer/data/mysql/sysprefs.sql | 1 + > .../prog/en/modules/admin/preferences/logs.pref | 6 ++++++ > 3 files changed, 20 insertions(+) > create mode 100644 installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql > >diff --git a/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql b/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql >new file mode 100644 >index 0000000..aca2ee3 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql >@@ -0,0 +1,13 @@ >+INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES >+('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); >+ >+-- $DBversion = "16.06.00.XXX"; >+-- if ( CheckVersion($DBversion) ) { >+-- $dbh->do(q{ >+-- INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES >+-- ('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); >+-- }); >+ >+-- print "Upgrade to $DBversion done (Bug 14642: Add logging of hold modifications)\n"; >+-- SetVersion($DBversion); >+-- } >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index cd0f8bf..099db56 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -167,6 +167,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('HighlightOwnItemsOnOPAC','0','','If on, and a patron is logged into the OPAC, items from his or her home library will be emphasized and shown first in search results and item details.','YesNo'), > ('HighlightOwnItemsOnOPACWhich','PatronBranch','PatronBranch|OpacURLBranch','Decides which branch\'s items to emphasize. If PatronBranch, emphasize the logged in user\'s library\'s items. If OpacURLBranch, highlight the items of the Apache var BRANCHCODE defined in Koha\'s Apache configuration file.','Choice'), > ('HoldFeeMode','not_always','always|not_always','Set the hold fee mode','Choice'), >+('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'), > ('HoldsQueueSkipClosed', '0', NULL, 'If enabled, any libraries that are closed when the holds queue is built will be ignored for the purpose of filling holds.', 'YesNo'), > ('HoldsToPullStartDate','2',NULL,'Set the default start date for the Holds to pull list to this many days ago','Integer'), > ('HomeOrHoldingBranch','holdingbranch','holdingbranch|homebranch','Used by Circulation to determine which branch of an item to check with independent branches on, and by search to determine which branch to choose for availability ','Choice'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref >index 8d6c4c8..4aa5790 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref >@@ -31,6 +31,12 @@ Logging: > off: "Don't log" > - when fines are charged, paid, or forgiven. > - >+ - pref: HoldsLog >+ choices: >+ on: Log >+ off: "Don't log" >+ - any actions on holds (create, cancel, suspend, resume, etc). >+ - > - pref: IssueLog > choices: > on: Log >-- >2.9.0 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '16

26 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #29 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Marcel de Rooy from comment #28) > (In reply to M. Tompsett from comment #27) > > Why did you change everything to the hashref references? > > my ($parameters) = @_; > > my $format = $parameters->{format}; > > ... > > block at the top and all the other code wouldn't need to be changed. > > Only a few vars are referenced more than once or twice. Even without > comparison etc. What is the status of this one? -- You are receiving this mail because: You are watching all bug changes.

1 0