July 2016 - Koha-bugs - lists.koha-community.org

[Bug 5456] Create a link to opac-ics.pl
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '16

25 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53670|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron(a)veron.ch> --- Created attachment 53671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53671&action=ed… Bug 5456 - Create a link to opac-ics.pl opac-ics.pl was added to Koha back in 2007, but there has not been a link to it from anywhere. This patch adds the link from the main view on /cgi-bin/koha/opac-user.pl, and makes some changes to opac-ics.pl itself. Changes to opac-ics.pl: - Update the code to use date and time for when a loan is due - Use dt_from_string to turn a MySQL time and date into a DateTime - Add a timestamp and a UID (these were reported as necessary by a couple of iCal validators) - Remove DTEND from events, since we now have time as well as date for when a loan is due - For loans that are overdue, set the DTSTART to now(), to avoid creating calendar events in the past - Use a template to generate text strings, to make them translatable To test: - Apply the patch - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. - Sign off and go thee merrily on thine way. Update 2016-07-25 - Force date_due to UTC to avoid problematic timezone info like this: DTSTART:TZID=Europe/Zurich:20160724T235900 - Remove quotes from summary and description Followed test plan, koha.ics file successfully imported to Thunderbird calendar Signed-off-by: Marc <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '16

25 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Marc Véron <veron(a)veron.ch> --- Testing: - EnableRedirectGuaranteeEmail on - Both guarantor and guarantee have valid email address Messaging preferences: - Guarantee: all on - Guarantor: all on -Trigger mail (e.g. Checkout), run process_message_queue.pl Result: Mail goes to both (as expected) Messaging preferences: - Guarantee: all on - Guarantor: all off - Trigger mail (e.g. Checkout), run process_message_queue.pl Result: Mail goes to both (as expected) Messaging preferences: - Guarantee: all off - Guarantor: all on - Trigger mail (e.g. Checkout), run process_message_queue.pl Result: No mail (as expected) Messaging preferences: - Guarantee: all off - Guarantor: all off - Trigger mail (e.g. Checkout), run process_message_queue.pl Result: No mail (as expected) Running tests: t/db_dependent/Letters.t ------------------------ # Failed test 'With EnableRedirectGuaranteeEmail on, Message is sent to the guarantor's email address.' # at t/db_dependent/Letters.t line 193. # got: 'toto(a)exemple.com' # expected: 'guarantor(a)example.com' Fake sendmail at t/db_dependent/Letters.t line 32. # Failed test 'With EnableRedirectGuaranteeEmail on, message fails if guarantor has no address.' # at t/db_dependent/Letters.t line 198. # got: 'sent' # expected: 'failed' Fake sendmail at t/db_dependent/Letters.t line 32. # Looks like you planned 74 tests but ran 80. # Looks like you failed 2 tests of 80 run. t/db_dependent/Letters.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/74 subtests Test Summary Report ------------------- t/db_dependent/Letters.t (Wstat: 512 Tests: 80 Failed: 8) Failed tests: 30-31, 75-80 Non-zero exit status: 2 Parse errors: Bad plan. You planned 74 tests but ran 80. t/db_dependent/Members.t ------------------------ t/db_dependent/Members.t .. 1/79 "my" variable $guarantee masks earlier declaration in same scope at t/db_dependent/Members.t line 331. t/db_dependent/Members.t .. 2/79 # Failed test 'GetNoticeEmailAddress returns correct value when EnableRedirectGuaranteeEmail is activated' # at t/db_dependent/Members.t line 187. # got: 'guanrantee@email.test,Marie@work.com' # expected: 'Marie(a)work.com' t/db_dependent/Members.t .. 79/79 # Looks like you planned 79 tests but ran 81. # Looks like you failed 1 test of 81 run. t/db_dependent/Members.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/79 subtests Test Summary Report ------------------- t/db_dependent/Members.t (Wstat: 256 Tests: 81 Failed: 3) Failed tests: 27, 80-81 Non-zero exit status: 1 Parse errors: Bad plan. You planned 79 tests but ran 81. Files=1, Tests=81, 3 wallclock secs ( 0.04 usr 0.00 sys + 1.96 cusr 0.13 csys = 2.13 CPU) Result: FAIL Setting to FQA because of the tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '16

25 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #97 from M. Tompsett <mtompset(a)hotmail.com> --- PerlDependencies issue. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5456] Create a link to opac-ics.pl
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '16

25 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53666|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 53670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53670&action=ed… Bug 5456 - Create a link to opac-ics.pl opac-ics.pl was added to Koha back in 2007, but there has not been a link to it from anywhere. This patch adds the link from the main view on /cgi-bin/koha/opac-user.pl, and makes some changes to opac-ics.pl itself. Changes to opac-ics.pl: - Update the code to use date and time for when a loan is due - Use dt_from_string to turn a MySQL time and date into a DateTime - Add a timestamp and a UID (these were reported as necessary by a couple of iCal validators) - Remove DTEND from events, since we now have time as well as date for when a loan is due - For loans that are overdue, set the DTSTART to now(), to avoid creating calendar events in the past - Use a template to generate text strings, to make them translatable To test: - Apply the patch - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. - Sign off and go thee merrily on thine way. Update 2016-07-25 - Force date_due to UTC to avoid problematic timezone info like this: DTSTART:TZID=Europe/Zurich:20160724T235900 - Remove quotes from summary and description -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5456] Create a link to opac-ics.pl
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '16

24 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 --- Comment #3 from Marc Véron <veron(a)veron.ch> --- Nice feature! However, I can not import to thunderbird calendar. This is what I get as koha.ics: BEGIN:VCALENDAR VERSION:2.0 PRODID:Data::ICal 0.21 BEGIN:VEVENT DESCRIPTION:Your copy of ""Pfützen schreien so laut ihr Licht" :" (barcode 1234567890) is due back at the library today DTSTAMP:20160724T050512Z DTSTART:TZID=Europe/Zurich:20160724T235900 SUMMARY:""Pfützen schreien so laut ihr Licht" :" is due UID:issue-1@ END:VEVENT END:VCALENDAR If I fix the DTStart as follows, it imports OK: BEGIN:VCALENDAR VERSION:2.0 PRODID:Data::ICal 0.21 BEGIN:VEVENT DESCRIPTION:Your copy of ""Pfützen schreien so laut ihr Licht" :" (barcode 1234567890) is due back at the library today DTSTAMP:20160724T050512Z DTSTART:20160724T235900 TZID:Europe/Zurich SUMMARY:""Pfützen schreien so laut ihr Licht" :" is due UID:issue-1@ END:VEVENT END:VCALENDAR Additionally, I think there are to much quotes in DESCRIPTION -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5456] Create a link to opac-ics.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '16

23 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 --- Comment #2 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 53666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53666&action=ed… Bug 5456 - Create a link to opac-ics.pl opac-ics.pl was added to Koha back in 2007, but there has not been a link to it from anywhere. This patch adds the link from the main view on /cgi-bin/koha/opac-user.pl, and makes some changes to opac-ics.pl itself. Changes to opac-ics.pl: - Update the code to use date and time for when a loan is due - Use dt_from_string to turn a MySQL time and date into a DateTime - Add a timestamp and a UID (these were reported as necessary by a couple of iCal validators) - Remove DTEND from events, since we now have time as well as date for when a loan is due - For loans that are overdue, set the DTSTART to now(), to avoid creating calendar events in the past - Use a template to generate text strings, to make them translatable To test: - Apply the patch - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. - Sign off and go thee merrily on thine way. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5456] Create a link to opac-ics.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '16

23 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '16

23 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14793] New cataloguing plugin unimarc_field_225a_bis
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle(a)bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Julian! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16948] New: 'Return to batch item deletion' button should only show when there are items that could not be deleted
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Bug ID: 16948 Summary: 'Return to batch item deletion' button should only show when there are items that could not be deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Referring to Owen Leonard's comment from Bug 15824: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824#c18 Having both the link and the button makes sense with batch item modifications when the list of modified items is displayed. On the batch item deletion confirmation screen I think we should move the button into the [% IF ( not_deleted_loop ) %] block so that it is only shown if the page is listing items which could not be deleted. -- You are receiving this mail because: You are watching all bug changes.

1 9