July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50860|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50985|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53631&action=ed… Bug 15451: (followup) fix filename extension for csv file This patch does the same as basket/downloadcart.pl to set '.csv' as filename extension for downloadshelf.pl To test: 1) Define a CSV MARC profile 2) On staff download a list, extension is '.NN' with 'NN' the CSV profile id. 3) Apply the patch 4) Download again, check extension is now '.csv' Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53630&action=ed… Bug 15451: Do not considered a Resultset as a Result The previous calls were wrong, but there is something bad with the DB structure: export_format.profile should be a unique key. This patch fixes the previous calls and add a FIXME not to forget to fix the DB structure. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Previous test where done with all patches applied, including this one, and all worked. No errors Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53629&action=ed… Bug 15451: Koha::CsvProfiles - Remove the residue This patch erase all traces of C4::Csv since it's not used anymore. All occurrences have been replaced by previous patches to use Koha::CsvProfiles. Note that GetMarcFieldsForCsv was not used prior this patch set. Test plan: git grep 'C4::Csv' should not return any result. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> No more traces of the file. This produces a koha-qa fail, due to the missing file. No other errors Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53628&action=ed… Bug 15451: Koha::CsvProfiles - Remove GetCsvProfile This subroutine just returned a csv profile for a given id. It is replaced in this patch by a call to Koha::CsvProfiles->find. There is nothing to test here, these changes have been tested in previous patches. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53627&action=ed… Bug 15451: Koha::CsvProfiles - Remove GetCsvProfileId This subroutine returned the export_format_id for a given profile name. This can be done easily with the Koha::CsvProfiles->search method. Test plan: Export records using the misc/export_records.pl script and the export tool. If you are exporting using the MARC format, the profile filled in the pref ExportWithCsvProfile will be used (or the one passed in parameter of misc/export_records.pl). If you are exporting using the CSV format, you can choose a profile in the dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Exported using tool & cmd, marc & csv. Pref is used. No errors Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53626&action=ed… Bug 15451: Koha::CsvProfiles - Remove GetCsvProfiles This subroutine did the same job as GetCsvProfilesLoop, so this patch applies the same changes as the previous patch. Test plan: 1/ Claim some serials, sql profiles should be listed 2/ Export records using the export tool. MARC profiles should be listed. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Listed sql & marc profiles No errors Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53625&action=ed… Bug 15451: Koha::CsvProfiles - Remove GetCsvProfilesLoop This subroutine returned the csv profiles for a given type. This could be done easily with the new Koha::CsvProfiles->search method. Test plan: To do at the OPAC and staff interface! 1/ Export a list using a CSV profile 2/ Export your CART using a CSV profile Note that only MARC profiles should be available. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Tested on staff/opac & cart/list Small problem on filename extension fixed in followup. No errors Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53624&action=ed… Bug 15451: Rewrite the csv profile tool script This page was inconsistent with the other admin and tool pages. The 2 tabs 'New profile' and 'Edit existing profile' were useless, the ergonomic needs to be revisited. This patch applies the same script/page structure as others: by default a table containing all csv profiles is displayed with 2 action links: edit and delete. Test plan: 1/ Create 1+ CSV profiles, with different types (marc and sql) 2/ Update some values using the Edit link 3/ Delete a CSV profile Note: When deleting a CSV profile, it would be great to warn the user if it is used. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> No problems on create, update and delete. No errors Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0