August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jacek Ablewicz from comment #42) > UpdateFine() calling convention got changed in Bug 15675. Bug 15675 has some > other unpleasant side effects (see Bug 17135) which are not yet resolved, > and it looks like this report may be helpful for fixing Bug 17135 (?). IMO > both those reports desperately need some more attention - Bug 17135 is > pretty nasty, and stable / 16.05 is affected by it as well. OK Our comments crossed each other. The new report describes it too. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I tested by creating an overdue, backdating it, ran fines, renewed it. The fine is set to type F. That is ok. But we are not ready yet. What will happen if it gets overdue again? I backdated the due date and the last renewal date. Ran fines again. And here comes the problem: The accountline that has type F but still has the issue id(!), got updated with the new amount and was set back to FU. (So: old fine got lost!) UpdateFine does not respect the F type here; the issue id is leading. Note that in this case the test ..amount<>..amount in UpdateFine may be misleading too. How to solve this? Can we remove the issue id in accountlines after switching to F? Or should UpdateFine no longer update a F record although it has the right issue id, but add a new record? Please add a follow-up. This should be tested again. So reset to Needs Signoff. Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17135 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #42 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- UpdateFine() calling convention got changed in Bug 15675. Bug 15675 has some other unpleasant side effects (see Bug 17135) which are not yet resolved, and it looks like this report may be helpful for fixing Bug 17135 (?). IMO both those reports desperately need some more attention - Bug 17135 is pretty nasty, and stable / 16.05 is affected by it as well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Still working on this. Please wait.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jacek Ablewicz from comment #35) > (In reply to Marcel de Rooy from comment #34) > > > UpdateFine is not called with a param hash. Just hope that this changed over > > time while this patch was waiting for some attention.. > > It did. That helps :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54596&action=ed… Bug 14390: [QA Follow-up] UpdateFine should be passed a hash Renewing an overdue would not work. Log shows: renew: Can't use string ("2144746608") as a HASH ref while "strict refs" in use at C4/Overdues.pm line 508., referer: /cgi-bin/koha/circ/circulation.pl?borrowernumber=1 Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51629|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54595&action=ed… Bug 14390 [QA Followup] - Fix warning -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51628|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54594&action=ed… Bug 14390 [QA Followup] - Unit Test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '16

19 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51627|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54593&action=ed… Bug 14390 - Fine not updated from 'FU' to 'F' on renewal Test Plan: 1) Find an overdue checkout with a fine 2) Renew item, note fine is not closed out (Account type F) 3) Apply this patch 4) Find another overdue checkout with a fine 5) Renew item, note fine is now correctly closed out 6) Backdate a checkout to be already overdue ( but not have a fine since fines.pl hasn't run yet ) 7) Renew item, note a closed out fine is created Signed-off-by: Sean Minkel <sminkel(a)rcplib.org> -- You are receiving this mail because: You are watching all bug changes.

1 0