August 2016 - Koha-bugs - lists.koha-community.org

[Bug 15200] t/Creators.t fails when using build-git-snapshot
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle(a)bywatersolutions.com --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Mirko! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #53 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54525&action=ed… Bug 14504 - Changes missed while fixing patches -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #52 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54522&action=ed… Bug 14504: (QA followup) Fix delete_records_via_leader.pl call to DelItemCheck Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #51 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54521&action=ed… Bug 14504: (QA followup) Tidy tests This patch re-introduces the transaction into t/db_dependent/Items_DelItemCheck.t and does some cleaning on the touched tests so they raise less warnings. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #50 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54520&action=ed… Bug 14504: (QA followup) fix test transaction, book_on_loan -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #49 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54519&action=ed… bug 14504: (QA followup) fixing DelItemCheck arguments Remove $dbh as argument to C4::Items::DelItemCheck and C4::Items::ItemSafeToDelete, also change all calls to these functions throughout the codebase. Also remove remaining reference to 'do_not_commit' in t/db_dependent/Items_DelItemCheck.t Fixed doubled "$$" in C4/ImportBatch.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #48 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54518&action=ed… Bug 14504: (QA followup) use TestBuilder, remove do_not_commit Use t::lib::TestBuilder in t/db_dependent/Items_DelItemCheck.t Remove the option 'do_not_commit' from C4::Items::DelItemCheck. Whitespace cleanup. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #47 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54517&action=ed… bug 14504: use C4::Items::DelItemCheck in delete_items.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #46 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54516&action=ed… bug 14504: split logic from DelItemCheck() into ItemSafeToDelete() -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '16

16 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #45 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54515&action=ed… Bug 14504: (QA followup) * Fix POD warning. * Remove redundant 'use stric' and 'use warnings' * Remove $VERSION and --version option. * Remove --dry-run option * Split test for --help and check for @criteria into two separate pod2usage calls, enabling -msg on the latter. * Fix 'target_tiems' typo. * Test for holds on items to be deleted. * Fix whitespace * Fix test for holds. -- You are receiving this mail because: You are watching all bug changes.

1 0