August 2016 - Koha-bugs - lists.koha-community.org

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #38 from Owen Leonard <oleonard(a)myacpl.org> --- I find that it's not possible to make the "library" selection mandatory. Is there a reason for that? Note that there is a JS validation plugin available in the OPAC if you want to use it. See opac-memberentry.tt for an example. The plugin can be set up to validate a form based on the markup (requiring fields which are , so it's not necessary to dynamically configure the fields in the JS if you don't want to. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16830] New: koha-indexer still uses the deprecated -x option switch
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830 Bug ID: 16830 Summary: koha-indexer still uses the deprecated -x option switch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz To reproduce: - Run $ sudo koha-indexer --start kohadev => FAIL: You get a warning on your logs (/var/log/koha/kohadev/indexer-output.log: Warning: You passed -x which is already the default and is now deprecated -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #37 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- In this revised version I dropped the old form validation handler entirely, in favour of the "required" attributes as a sole method of enforcement. Not sure if the special treatment for old / legacy / non-compliant browsers is still needed? If deemed necessary, I may try to re-add such an event handler which will be more on par with the current coding guidelines. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #36 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 54021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54021&action=ed… Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC - part 2 Add 'OPACSuggestionMandatoryFields' syspref definition plus an atomic DB update for the new preference. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54018|0 |1 is obsolete| | Attachment #54019|0 |1 is obsolete| | --- Comment #35 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 54020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54020&action=ed… Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC This patch adds a configuration option which allows to define which fields should be mandatory for a patron purchase suggestion form in OPAC. Test plan: 1/ Apply patch. 2/ Play with the new OPACSuggestionMandatoryFields system preference (select some fields as manadatory, select all, deselect all, try to submit some suggestions with mandatory fields filled and/or not filled etc.) to ensure that required fields (and only required fields) are enforced in the browser to be filled. 3/ With all options deselected, 'Title' field should still be mandatory (by default). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #34 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 54019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54019&action=ed… Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC Add 'OPACSuggestionMandatoryFields' syspref definition plus an atomic DB update for the new preference. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54017|0 |1 is obsolete| | --- Comment #33 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 54018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54018&action=ed… Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC This patch adds a configuration option which allows to define which fields should be mandatory for a patron purchase suggestion form in OPAC. Test plan: 1/ Apply patch. 2/ Play with the new OPACSuggestionMandatoryFields system preference (select some fields as manadatory, select all, deselect all, try to submit some suggestions with mandatory fields filled and/or not filled etc.) to ensure that required fields (and only required fields) are enforced in the browser to be filled. 3/ With all options deselected, 'Title' field should still be mandatory (by default). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54016|0 |1 is obsolete| | --- Comment #32 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 54017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54017&action=ed… Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC Add 'OPACSuggestionMandatoryFields' syspref definition plus an atomic DB update for the new preference. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '16

05 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34544|0 |1 is obsolete| | Attachment #34545|0 |1 is obsolete| | Attachment #34546|0 |1 is obsolete| | Attachment #34547|0 |1 is obsolete| | Attachment #35830|0 |1 is obsolete| | --- Comment #31 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 54016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54016&action=ed… Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC This patch adds a configuration option which allows to define which fields should be mandatory for a patron purchase suggestion form in OPAC. Test plan: 1/ Apply patch. 2/ Play with the new OPACSuggestionMandatoryFields system preference (select some fields as manadatory, select all, deselect all, try to submit some suggestions with mandatory fields filled and/or not filled etc.) to ensure that required fields (and only required fields) are enforced in the browser to be filled. 3/ With all options deselected, 'Title' field should still be mandatory (by default). -- You are receiving this mail because: You are watching all bug changes.

1 0