August 2016 - Koha-bugs - lists.koha-community.org

[Bug 10895] Tests for C4::Items GetHiddenItems
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14385 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10895] Tests for C4::Items GetHiddenItems
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 --- Comment #33 from M. Tompsett <mtompset(a)hotmail.com> --- This may still be applicable, at least conceptually, to bug 14385. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #14 from M. Tompsett <mtompset(a)hotmail.com> --- *** Bug 10589 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10589] Override OpacHiddenItems based on Patron Category
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #40 from M. Tompsett <mtompset(a)hotmail.com> --- I'm working on a refactor in bug 16335, so I'll close this for bug 14385 to move ahead. *** This bug has been marked as a duplicate of bug 14385 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Aleisha, as Mark told you in comment 3 and comment 5, your patch conflict with bug 10589 and bug 16335. Moreover you forgot the changes to sysprefs.sql and an atomic update file. Mark, bug 10589 is failed QA, do you plan to work on it? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #31) > (In reply to Marcel de Rooy from comment #30) > > I'm kind of exhausted in finding new ways to get this simple change in Koha. > > My goal was not to exhaust you, but just to make sure it was the best thing > to do. > Sorry about that. My suggestion was to ask on koha-devel what others think. No problem. But I prefer not to keep this report pending for another longer period of time. Moving it to custom :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #30) > I'm kind of exhausted in finding new ways to get this simple change in Koha. My goal was not to exhaust you, but just to make sure it was the best thing to do. Sorry about that. My suggestion was to ask on koha-devel what others think. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5456] Create a link to opac-ics.pl
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris(a)bigballofwax.co.nz |magnus(a)libriotech.no --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Magnus Enger from comment #8) Ok, let's push it and we will see later if we need to adapt something :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5456] Create a link to opac-ics.pl
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53671|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53831&action=ed… Bug 5456 - Create a link to opac-ics.pl opac-ics.pl was added to Koha back in 2007, but there has not been a link to it from anywhere. This patch adds the link from the main view on /cgi-bin/koha/opac-user.pl, and makes some changes to opac-ics.pl itself. Changes to opac-ics.pl: - Update the code to use date and time for when a loan is due - Use dt_from_string to turn a MySQL time and date into a DateTime - Add a timestamp and a UID (these were reported as necessary by a couple of iCal validators) - Remove DTEND from events, since we now have time as well as date for when a loan is due - For loans that are overdue, set the DTSTART to now(), to avoid creating calendar events in the past - Use a template to generate text strings, to make them translatable To test: - Apply the patch - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. - Sign off and go thee merrily on thine way. Update 2016-07-25 - Force date_due to UTC to avoid problematic timezone info like this: DTSTART:TZID=Europe/Zurich:20160724T235900 - Remove quotes from summary and description Followed test plan, koha.ics file successfully imported to Thunderbird calendar Signed-off-by: Marc <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5456] Create a link to opac-ics.pl
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0