September 2016 - Koha-bugs - lists.koha-community.org

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51647|0 |1 is obsolete| | --- Comment #73 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55419&action=ed… Bug 13321: Csv export - Display rrp and ecost with and without taxes If a basketgroup is exported as a CSV file, both prices should be displayed to avoid confusion. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51646|0 |1 is obsolete| | --- Comment #72 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55418&action=ed… Bug 13321: Tax and prices calculation - DB Changes This patch adds 7 columns to the aqorders table: * unitprice_tax_excluded * unitprice_tax_included * rrp_tax_excluded * rrp_tax_included * ecost_tax_excluded * ecost_tax_included * tax_value It also renames: * aqorders.gstrate with aqorders.tax_rate * aqbooksellers.gstrate with aqbooksellers.tax_rate The new columns are filled with the previous calculation method. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51645|0 |1 is obsolete| | --- Comment #71 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55417&action=ed… Bug 13321: Fix the prices calculation method Well, we have finally arrived here \o/ The method where the prices are calculated uses the equations listed on the wiki page (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC) The ecost is calculated from the rrp (using the discount and the tax rate). That's why we removed the ability to edit this value. That's why we remove the ability to edit the ecost on ordering in a previous commit (bug 12840). The total is now calculated in the scripts. That's why this patch removes lines in the test file. In C4::Acquisition::populate_order_with_prices, the calculation on receiving must depend on the 'invoiceincgst' supplier parameter, and not listincgst (which is used on ordering). It also removes the rounding errors, now we store "exact" values in DB (10^-6). The values will be displayed using the Price TT plugin it will round the values for us. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51644|0 |1 is obsolete| | --- Comment #70 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55416&action=ed… Bug 13321: use the populate_with_prices where needed Now we need to calculate the prices (ecost, rrp, unitprice) and tax (tax_rate, tax_value) when the price is set for an order. This only appends in the 3 files impacted by this patch. addorder*.pl on ordering finishreceive.pl on receiving Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51643|0 |1 is obsolete| | --- Comment #69 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55415&action=ed… Bug 13321: Rename variables This patch renames the variable according to the new DB column names * gste => tax_excluded * gsti => tax_included * gstrate => tax_rate * gstvalue => tax_value This patch also modify the ModReceiveOrder subroutine: * Edit vendor note on receiving is not possible, so the code should not permit that. * Update ModReceiveOrder to pass a hashref And that's all! git grep on gste, gsti, gstrate and gstvalue should not return any code that can be executed. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10455] remove redundant 'biblioitems.marc' field
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #38 from Mason James <mtj(a)kohaaloha.com> --- I've tested Jonathan's 9 patches. Everything seems to work as expected, and the patches all look good to me I used the misc/devel/update_dbix_class_files.pl script to build the Koha/Scheme/Results/* files, before testing delete_records_via_leader.pl thanks Jonathan! :0) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17283] New: Batch "upload" script
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17283 Bug ID: 17283 Summary: Batch "upload" script Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz A basic batch upload script I used to put >1000 PDFs into Koha. I am not planning to work more on this ATM, but it might be useful as a starting point for others. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 10455] remove redundant 'biblioitems.marc' field
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #37 from Mason James <mtj(a)kohaaloha.com> --- Created attachment 55410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55410&action=ed… Bug 10455: Fix tests Signed-off-by: Mason James <mtj(a)kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10455] remove redundant 'biblioitems.marc' field
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #36 from Mason James <mtj(a)kohaaloha.com> --- Created attachment 55409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55409&action=ed… Bug 10455: Remove MARC21_utf8_flag_fix.pl Is this script still in use? It uses the biblioitems.marc field so if it's still useful it will need to be rewritten. Signed-off-by: Mason James <mtj(a)kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10455] remove redundant 'biblioitems.marc' field
by bugzilla-daemon＠bugs.koha-community.org 09 Sep '16

09 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #35 from Mason James <mtj(a)kohaaloha.com> --- Created attachment 55408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55408&action=ed… Bug 10455: (follow-up 3) Remove biblioitems.marc Signed-off-by: Mason James <mtj(a)kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

1 0