September 2016 - Koha-bugs - lists.koha-community.org

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55012|0 |1 is obsolete| | --- Comment #56 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 55247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55247&action=ed… Bug 14060: Remove readonly attributes on date inputs In order to remove accessibility issues due to the readonly attributes on date inputs, this patch will remove them and introduce a javascript validation on them. This patch is not perfect for some reason: I didn't manage to force the user to select a valid date. One solution would be to reopen the datepicker plugin until a valid date is inserted. But it could be annoying for users (and for me: I did not manage to implement this solution). You will note that input is emptied if the date is not valid. This is a quick and efficient solution to prevent submitting invalid date and make Koha explodes. A proper solution would be to implement the check server side send a friendly message to the user. Test plan: For all inputs, try an invalid and a valid date. 1/ Debar a patron 2/ On the checkout tables (circulation and moremember), add a renewal due date (at the bottom of the tables) 3/ On the checkout page, specify a due date 4/ On the return page, specify a return date 5/ On the invoice page (acquisition module), enter a shipment and billing date 6/ On the invoice search page (invoices.pl) use filters shipment and billing dates 7/ On the offline circ page, specify a due date 8/ On the edit patron page (memberentry), add a debarment 9/ On the reserve page (reserve/request.pl), use the date inputs to suspend until a defined date 10/ Edit patrons in a batch (tools/modborrowers.pl) and use the registration and expiry date inputs Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14610] Add ability to place article requests in Koha
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #194 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This feature may also be referred to as Scan and Deliver. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17254] New: Scan and Deliver-feature ( mail selected digitized material)
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17254 Bug ID: 17254 Summary: Scan and Deliver-feature (mail selected digitized material) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Several special libraries, university libraries etc. offer a feature to scan selected chapters of books, or articles of serials and mail a PDF within a few days. Free or for a small contribution. How could we implement such a feature in Koha ? Any thoughts? -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 14610] Add ability to place article requests in Koha
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #193 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- *** Bug 17254 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14610] Add ability to place article requests in Koha
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #55 from Mirko Tietgen <mirko(a)abunchofthings.net> --- (In reply to Jonathan Druart from comment #54) > Created attachment 55246 [details] [review] > Bug 14060: Improve regex to limit year to 4 integers > > 01/01/01984 should not be considered as a valid date. I hope Koha stays free software until the year 10000, or this will lead to some library having to sponsor a new ILS again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #54 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 55246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55246&action=ed… Bug 14060: Improve regex to limit year to 4 integers 01/01/01984 should not be considered as a valid date. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7677] New area in subscriptions and new function when receiving
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '16

06 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #96 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 45940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45940 Bug 7677: UT: add unit tests for GetPreviousSerialid Review of attachment 45940: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=767…) ----------------------------------------------------------------- ::: t/db_dependent/Serials_2.t @@ +255,5 @@ > +is( GetPreviousSerialid( $subscriptionid, 1 ), $serialid2, "get previous serialid with 1" ); > +is( GetPreviousSerialid( $subscriptionid, 2 ), $serialid1, "get previous serialid with 2" ); > +is( GetPreviousSerialid( $subscriptionid, 3 ), undef, "get previous serialid with 3, does not exist" ); > + > +$dbh->rollback; This rollback should not have been added by this patch (added by a wrong merge conflict). -- You are receiving this mail because: You are watching all bug changes.

1 0