September 2016 - Koha-bugs - lists.koha-community.org

[Bug 13921] XSLT Literary Formats Not Showing
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #44 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks for the followup Katrin! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #58 from Julian Maurice <julian.maurice(a)biblibre.com> --- First 2 patches rebased on master 4 new patches added to fix some issues -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #57 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55136&action=ed… Bug 8995: Fix and simplify usage of syspref OpenURLImageLocation There were still references to the OPAC 'prog' theme in XSL files Now, when using a relative URL, we have to give the full path -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #56 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55135&action=ed… Bug 8995: Tell about the new sysprefs in COinSinOPACResults description -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #55 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55134&action=ed… Bug 8995: Fix URL generation when the URL in syspref has a query part -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #54 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55133&action=ed… Bug 8995: Remove useless code OpenURL link display is done in XSLT only, so this code is now useless -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48372|0 |1 is obsolete| | --- Comment #53 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55132&action=ed… Bug 8995: Update opac.css -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48371|0 |1 is obsolete| | --- Comment #52 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 55131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55131&action=ed… Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8030] Change pickup location of a hold from patron record
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '16

02 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0