January 2017 - Koha-bugs - lists.koha-community.org

[Bug 15541] Prevent normalization during matching/import process
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57852|0 |1 is obsolete| | --- Comment #34 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 59295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59295&action=ed… Bug 15541 - Prevent normalization during matching/import process This patch allows you to use the "qualifier,qualifier" syntax in the Record Matching Rules "Search Index" when using the QueryParser. While QueryParser doesn't support this syntax, it will now fallback correctly to non-QueryParser functionality. Without the patch, your search will just fail silently. This patch also adds a "skip_normalize" option to C4::Search::SimpleSearch(), and uses the option during C4::Matcher::get_matches. This prevents the s/:/=/g and s/=/:/g normalization. This normalization is heavy-handed, and while it is necessary sometimes to generate a valid CCL query or QueryParser query, C4::Matcher::get_matches() already produces a valid CCL query, so we don't need to do this normalization. Additionally, this normalization causes problems when you use a Zebra register which isn't normalized: namely the "u" register. Strings are stored "as is", so http://localhost/koha/resource/1 is stored as is during indexing. When you search, you need to pass the exact same thing through the query to get a match. Using http=//localhost/koha/resource/1 in your query will yield zero results. _TEST PLAN_ 0) Apply patch 1) Create a Record Matching Rule in Koha with the following details: Matching rule code: TEST Description: Test Match threshold: 100 Record type: Bibliographic Match point 1: Search index: id-other,st-urx Score: 100 Tag: 024 Subfields: a Normalization rule: None 2) Create a record in Koha with an indexable URI 2a) Default framework 2b) 024 $a http://koha-community.org/test $2 uri 2c) 040 $c test 2d) 245 $a This is a test record 2e) 942 $c Books 2f) Save (save again if cautioned about missing fields as these should autofill) 3) Do a full re-index of Zebra 4) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc) 5) Go to "Stage MARC records for import" 5a) Upload your .marc file. 5b) Change your "Record matching rule" to "Test" 5c) Click Stage for import 9) It should say "1 records with at least one match in catalog per matching rule "Test". NOTE: For completeness, you can go through this process on a clean master branch, and note that it will say '0 records with at least one match in catalog per matching rule "TEST"' Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 --- Comment #6 from Gracie <grace.mcky(a)gmail.com> --- Created attachment 59290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59290&action=ed… Bug 7143: [QA Follow-up] Handling tabs Editing spaces before releases and developer: 876,$s/ \+releases$/^Ireleases/ (20 substitutions) 876,$s/ \+developer$/^Ideveloper/ (7 substitutions on 7 lines) Editing spaces between date and text: 876,$s/2016 \+/2016^I/ 876,$s/2017 \+/2017^I/ Fixed a few single spaces too. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Display on Timeline tab looks good now. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Gracie <grace.mcky(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky(a)gmail.com --- Comment #5 from Gracie <grace.mcky(a)gmail.com> --- The above patch is only for half of the bug, I decided to separate the OPAC and Staff sides of the bug to make it easier to see the changes made -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 --- Comment #4 from Gracie <grace.mcky(a)gmail.com> --- Created attachment 59289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59289&action=ed… Bug 7556 - Use "preventDoubleFormSubmit()" more in the OPAC Test Plan: - Look at commit to see file changes and then test each form making sure you can't double submit This is for the OPAC side -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Gracie <grace.mcky(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Luke Honiss <luke.honiss(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luke.honiss(a)gmail.com Status|Needs Signoff |Failed QA --- Comment #42 from Luke Honiss <luke.honiss(a)gmail.com> --- Tests on db_dependent/Letters.t and b_dependent/Members.t failed when I tested this. Setting to failed QA for now. Everything else seemed to work fine though. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15590] Next issue skipped if planned date is 1/1/2016
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15590 Luke Honiss <luke.honiss(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #47 from Luke Honiss <luke.honiss(a)gmail.com> --- You have left in the '>>>>>>> BUG XXXXX' when resolving the conflicts in Koha/Patron.pm (line 644) and installer/data/mysql/kohastructure.sql (lines 4077 and 4078). I cannot work out how to add a patron to a club however. If you could walk me through the process that would be awesome. Also when adding another field in the creation of a template there is no colon after the field name unlike the default fields when editing the club. There is also an extra full stop in the tools homepage under the 'Patron clubs' link. Looks like it will be a great feature when finished! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia(a)hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #153 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Patch does not apply Applying: Bug 11708: Add aqbasketgroups.closeddate Applying: Bug 11708: Unit tests for aqbasketgroups.closeddate Applying: Bug 11708: basketgroup.pl can now display basketgroups for all suppliers Using index info to reconstruct a base tree... M acqui/basketgroup.pl M koha-tmpl/intranet-tmpl/prog/css/datatables.css M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9692] Add a checkbox to display statistical fields in basket.tt
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Emma <emma.nakamura.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59202|0 |1 is obsolete| | --- Comment #11 from Emma <emma.nakamura.smith(a)gmail.com> --- Created attachment 59283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59283&action=ed… Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt -- You are receiving this mail because: You are watching all bug changes.

1 0