January 2017 - Koha-bugs - lists.koha-community.org

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #42 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 58820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58820&action=ed… Bug 12461 [QA Followup] - Changes based on suggestions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58818|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 58819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58819&action=ed… Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50422|0 |1 is obsolete| | Attachment #50427|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 58818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58818&action=ed… Bug 12461 [QA Followup] - Changes based on suggestions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #24 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #23) > (In reply to Alex Arnaud from comment #22) > > For me there is two case: > > > > 1) The expiration date set by the patron is higher than the calculated > > expiration date (that take into account pickup delay and holiday). In this > > case, i think it is quite fair to overwrite the patron expiration date since > > he is not supposed to keep the item waiting beyond the library delay. This > > is what this patch does. > > > > 2) The patron expiration date is before the calculated expiration date. As > > the patron don't need the item after its own date, we could overwrite > > expirationdate with the one calculated. We need a adjustment to have this > > behavior. > > As indicated before, I would not overwrite the expiration date. > What about comment19 ? Not sure to understand. (In reply to Marcel de Rooy from comment #19) > (In reply to Andreas Hedström Mace from comment #18) > > Without having actually tested this bug, only reading the discussion, I > > would say that I have to agree with Sonia. > > > > As this new date is set after the material is checked in, it doesn't appear > > (at least to me) that the expire date set by the patron would be valuable > > anymore. And the added value of excluding dates that the library is closed > > from the number of day in ReservesMaxPickUpDelay, seem greater than any > > negative impact. > > Hi Andreas, > Thx for your feedback. > I read it again too now. This patch tries to achieve its goal by modifying > the expirationdate, while it actually should change this select in > CancelExpiredReserves? > > my $query = "SELECT * FROM reserves WHERE TO_DAYS( NOW() ) - TO_DAYS( > waitingdate ) > ? AND found = 'W' AND priority = 0"; > > If the holiday stuff is taken into account here, I am having the impression > that we achieve the same. Mabye Sonia or Alex can respond to that? The code here is just simplified since the expirationdate (with max pickup delay + holiday) has already been set at the check in time. So we just need to fetch reserves whose expirationdate is over. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |julian.maurice(a)biblibre.com --- Comment #16 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #12) > 1/ Should not we update the histenddate if it has been set? I don't know what the expected behaviour is here. Any serials expert around ? > 2/ Could we imagine fixing existing DB entries? We could imagine, but is it possible to know if an histenddate has been set by a renewal or by hand ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #15 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58815&action=ed… Bug 7728: QA fixes - Remove useless comments - Use Koha::Objects::find instead of Koha::Objects::search -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47303|0 |1 is obsolete| | --- Comment #14 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58814&action=ed… BZ 7728 adding unit test test plan: * run without the patch, the test will fail * run with the patch, the test will pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45776|0 |1 is obsolete| | --- Comment #13 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58813&action=ed… Bug 7728: fix subs history end date consistency Without this patch, there is an inconsistency in subscriptions: * a new subscription has no history end date set (as expected) * if you renew it, a date is set. This patch removes the setting of the history end date during renewal Test plan: * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set * renew the subscription => a date has been set * apply the patch * create another subscription * renew it => no history end date has been set * sign-off Signed-off-by: beroud <isabelle.beroud(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '17

11 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Alex Arnaud from comment #22) > For me there is two case: > > 1) The expiration date set by the patron is higher than the calculated > expiration date (that take into account pickup delay and holiday). In this > case, i think it is quite fair to overwrite the patron expiration date since > he is not supposed to keep the item waiting beyond the library delay. This > is what this patch does. > > 2) The patron expiration date is before the calculated expiration date. As > the patron don't need the item after its own date, we could overwrite > expirationdate with the one calculated. We need a adjustment to have this > behavior. As indicated before, I would not overwrite the expiration date. What about comment19 ? -- You are receiving this mail because: You are watching all bug changes.

1 0