January 2017 - Koha-bugs - lists.koha-community.org

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40161|0 |1 is obsolete| | --- Comment #77 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58748&action=ed… Bug 12395: Make received orders table consistent with pending orders table (links of More column) Also change "Created by" with "Ordered by" in receive page. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40139|0 |1 is obsolete| | --- Comment #76 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58747&action=ed… Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40137|0 |1 is obsolete| | --- Comment #75 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58746&action=ed… Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40136|0 |1 is obsolete| | --- Comment #74 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58745&action=ed… Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. Patch updated with use of atomic update. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #46 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58743&action=ed… Bug 11999: Remove 'alreadyReserved' check in CanBookBeReserved Since bug 14695 it is possible to reserve more than one item per biblio Also fix bad use of $item -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50225|0 |1 is obsolete| | --- Comment #45 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58742&action=ed… Bug 11999: Check for age restriction in CanBookBeReserved + improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50224|0 |1 is obsolete| | --- Comment #44 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 58741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58741&action=ed… Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] returnBeforeExpiry and closed day
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57562|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 58740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58740&action=ed… Bug 11580 - If returnBeforeExpiry is ON, use calendar to calculate return date not on closed day (depending on useDaysMode) Test plan: 1. ReturnBeforeExpiry is activated 2. useDaysMode is different from "circulation rules only" 3. Set expiry date of a patron to a near date 4. Set a closed day on calendar for this date 5. Do a checkout Without patch, return date will be patron expiration date With the patch, return date will be last open day before patron expiration day Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 11580] returnBeforeExpiry and closed day
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '17

10 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0