October 2017 - Koha-bugs - lists.koha-community.org

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19541 [Bug 19541] Remove notifiactiondate and reminderdate from reserves/old_reserves tables -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #38 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Jonathan Druart from comment #36) > Great job Josef! > > It seems that notificationdate and reminderdate are not used, why do you > want to display them? :) I wanted to remove it completely on another report... But for now I've just added followup to make these two column hidden by default. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #37 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 68756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68756&action=ed… Bug 14919: (followup) Make notificationdate and reminderdate columns hidden by default -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13208] More complete breadcrumbs when cancelling an order
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #38) > Yes, always a new bug after things are pushed (no confusion in release notes > etc.) If it is not backported yet and the fix is trivial I prefer a follow-up on the same bug report and push it directly without the SO+QA steps. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11210] Allow partial writeoff
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67583|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 68754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68754&action=ed… Bug 11210 - Writeoff partial amounts Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount of a fine. Test plan: 0) Go to the Fines tab of a test patron's profile 1) Create a fine if there are none (under the Manual invoice tab) 2) Go to the "Pay fines" tab 3) Press the write off button on the corresponding account line Without patch, you'll be asked to confirm, but will not be able to edit the amount With patch, you'll be able to edit the amount. Followed test plan, patch worked as described. Also ran QA test tool and modified files passed Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11210] Allow partial writeoff
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Great job Josef! It seems that notificationdate and reminderdate are not used, why do you want to display them? :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #42 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68752&action=ed… Bug 15486: (followup) Tidy table code for readability Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #41 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68751&action=ed… Bug 15486: Modify request.tt to handle the new error string This patch makes reserve/request.pl display a convenient error description when a hold cannot be placed due to the new daily limit configuration. To test: - Apply this patchset - Upgrade - Configure your circulation rules so there's a daily limit for holds - Place holds so the patron reaches the maximum - Place one more hold - Notice the hold cannot be placed and a convenient error message is displayed. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '17

27 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68732|0 |1 is obsolete| | Attachment #68733|0 |1 is obsolete| | Attachment #68734|0 |1 is obsolete| | Attachment #68735|0 |1 is obsolete| | --- Comment #40 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68750&action=ed… Bug 15486: Extend CanItemBeReserved so it handles daily holds limits This patch implements the required changes in C4::Reserves::CanItemBeReserved so it implements a daily limit on holds. It returns the 'tooManyReservesToday' string if the policy doesn't allow placing the hold. It returns 'OK' (current behaviour) otherwise. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: Tests fail because the error condition is not making CanItemBeReserved return the desired error code. - Apply this patch - Run: k$ prove t/db_dependent/Holds.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0