October 2017 - Koha-bugs - lists.koha-community.org

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68003|0 |1 is obsolete| | --- Comment #86 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 68009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68009&action=ed… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68002|0 |1 is obsolete| | --- Comment #85 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 68008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68008&action=ed… Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66938|0 |1 is obsolete| | --- Comment #84 from Julian Maurice <julian.maurice(a)biblibre.com> --- Comment on attachment 66938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66938 Bug 12802: Fix QA script issues Patch squashed with the main one -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66937|0 |1 is obsolete| | --- Comment #83 from Julian Maurice <julian.maurice(a)biblibre.com> --- Comment on attachment 66937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66937 Bug 12802: Fix if AutoEmailOpacUser is enabled Patch squashed with the main one -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66936|0 |1 is obsolete| | --- Comment #82 from Julian Maurice <julian.maurice(a)biblibre.com> --- Comment on attachment 66936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66936 Bug 12802: FIX use the first valid email address if noemail is needed Patch squashed with the main one -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #81 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 68007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68007&action=ed… Bug 12802: Make tests pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #80 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 68006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68006&action=ed… Bug 12802: Update all circulation alerts, not only the first one Since SendCirculationAlert can generate multiple entries in message_queue, it should update them all if pending messages already exist -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66940|0 |1 is obsolete| | --- Comment #79 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 68005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68005&action=ed… Bug 12802: Fix tests in Reserves.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66939|0 |1 is obsolete| | --- Comment #78 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 68004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68004&action=ed… Bug 12802: Fix tests in Letters.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '17

12 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66935|0 |1 is obsolete| | --- Comment #77 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 68003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68003&action=ed… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0