October 2017 - Koha-bugs - lists.koha-community.org

[Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '17

02 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 67502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67502&action=ed… Bug 10306: Allow controlfields in TransformKohaToMarc Since the interface allows you to connect a kohafield to a MARC controlfield, this routine should be able to handle that. Unfortunately it did not. Test plan: Change will be tested in Biblio/TransformKohaToMarc.t in the next patch. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '17

02 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66327|0 |1 is obsolete| | Attachment #66328|0 |1 is obsolete| | Attachment #66329|0 |1 is obsolete| | Attachment #66330|0 |1 is obsolete| | Attachment #66331|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 67501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67501&action=ed… Bug 10306: Core module changes for multiple mappings In order to allow multiple Koha to MARC mappings (for one kohafield), we need to adjust a few key routines in C4/Biblio.pm. This results in a few changes in dependent modules too. Note: Multiple mappings also include 'alternating' mappings. Such as the case of MARC21 260 and 264: only one of both fields will be used. Sub TransformMarcToKoha will handle that just fine; the opposite transformation is harder, since we do no longer know which field was the source. In that case TransformKohaToMarc will fill both fields. We only use that operation in Koha for items (in Acquisition and Cataloging). Sub GetMarcSubfieldStructure This sub used a selectall_hashref, which is fine as long as we have only one mapping for each kohafield. But as DBI states it: If a row has the same key as an earlier row then it replaces the earlier row. In other words, we lose the first mapping if we have two. This patch uses selectall_arrayref with Slice and rearranges the output so that the returned hash returns an arrayref of hashrefs for each kohafield. In order to improve consistency, we add an order clause to the SQL statement used too. Sub GetMarcFromKohaField This sub just returned one tag and subfield, but in case of multiple mappings we should return them all now. Note: Many calls still expect just one result and will work just fine: my ($tag, $sub) = GetMarcFromKohaField(...) A possible second mapping would be silently ignored. Often the sub is called for biblionumber or itemnumber. I would not recommend the use of multiple mappings for such fields btw. In case the sub is called in scalar context, it will return only the first tag (instead of the number of tags and subfields). Sub GetMarcSubfieldStructureFromKohaField This sub previously returned the hash for one kohafield. In scalar context it will behave like before: it returns the first hashref in the arrayref that comes from GetMarcSubfieldStructure. In list context, it returns an array of all hashrefs (incl. multiple mappings). The sub is not used in C4::Ris. Removed the use statement. Sub TransformKohaToMarc This sub got a second parameter: frameworkcode. Historically, Koha more or less assumes kohafields to be defined across all frameworks (see Koha to MARC mappings). Therefore it falls back to Default when it is not passed. When going thru all mappings in building a MARC record, it also supports multiple mappings. Note that Koha uses this routine in Acquisition and in Cataloging for items. Normally the MARC record is leading however and the Koha fields are derivatives for optimization and reporting. The added third parameter allows for passing a new option no_split => 1. We use this option in C4::Items::Item2Marc; if two item fields are mapped to one kohafield but would have different values (which would be very unusual), these values are glued together. When transforming to MARC again, we do not want to duplicate the item subfields, but we keep the glued value in both subfields. This operation only affects items, since we are not doing this reverse operation for biblio and biblioitem fields. Sub _get_inverted_marc_field_map This sub is a helper routine of TransformMarcToKoha, the opposite transformation. When saving a MARC record, all kohafields are extracted including multiple mappings. Suppose that you had both 260c and 264c in your record (which you won't), than both values get saved initially into copyrightdate like A | B. The additional code for copyrightdate will extract the first year from this string. A small fix in TransformMarcToKoha makes that it only saves a value in a kohafield if it is defined and not empty. (Same for concatenation.) Sub TransformMarcToKohaOneField This sub now just calls TransformMarcToKoha and extracts the requested field. Note that since we are caching the structure, this does not result in additional database access and is therefore performance-wise insignificant. We simplify code and maintenance. Instead of modifying the passed hashref, it simply returns a value. A call in C4::Breeding is adjusted accordingly. The routine getKohaField in Koha::MetadataRecord is redirected to TransformMarcToKohaOneField. NOTE: The fourth patch restructures/optimizes TransformMarcToKoha[OneField]. Sub get_koha_field_from_marc This sub can be removed. A call is replaced by TransformMarcToKohaOneField in C4::XISBN. Note: The commented lines for sub ModZebrafiles are removed (directly under TransformMarcToKohaOneField). Test plan: For unit tests and interface tests, please see follow-ups. Run qa tools in order to verify that the modules still compile well. Read the code changes and verify that they make sense. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19103] Stored XSS in itemtypes.pl - patron-attr-types.pl - matching-rules.pl
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '17

02 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19103 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19108] Stored XSS in multiple scripts
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '17

02 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19108 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19127] Stored XSS in csv-profiles.pl
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '17

02 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19127 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19393] New: Error date Returns
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '17

02 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19393 Bug ID: 19393 Summary: Error date Returns Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: carlos.cordovas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Hello friends I have koha Koha 16.1112000 on debian 9. I have a problem with the return time is two hours later than the actual return time. how to replicate the error. 1.- make a loan 2.- immediately return the book 3.- go to history of circulation and sort by date 4.- verify that the return time is two hours later this is the TZ / DATE / HWCLOCK configuration root@catalogo:/etc# timedatectl Local time: Sun 2017-10-01 19:01:59 -03 Universal time: Sun 2017-10-01 22:01:59 UTC RTC time: Sun 2017-10-01 22:03:00 Time zone: America/Santiago (-03, -0300) Network time on: no NTP synchronized: no RTC in local TZ: no root@catalogo:/etc# date Sun Oct 1 19:02:01 -03 2017 root@catalogo:/etc# hwclock 2017-10-01 19:03:05.606684-0300 root@catalogo:/etc# Sample from staff issues Date 19:01 https://snag.gy/c6dz37.jpg incorrect return time 22:04 https://snag.gy/cr90Kd.jpg Regards -Carlos -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 18777] New: Translatability: Get rid of exposed tt directives in opac-memberentry.tt
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '17

01 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Bug ID: 18777 Summary: Translatability: Get rid of exposed tt directives in opac-memberentry.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr The file opac-memberentry.tt exposes template directives to translation where translators should not be confronted with. Example from po file: "%s [%% UNLESS hidden.defined('B_address') && hidden.defined('B_address2') && " "hidden.defined('B_city') && hidden.defined('B_state') && hidden." "defined('B_zipcode') && hidden.defined('B_country') && hidden." "defined('B_phone') && hidden.defined('B_email') && hidden." "defined('contactnote') %%] " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 19130] New: K::A::Booksellers->search broken for attribute 'name'
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '17

01 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130 Bug ID: 19130 Summary: K::A::Booksellers->search broken for attribute 'name' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The current overloaded implementation doesn't allow to search for stuff that is suffix of a bigger word. For example, if you have - name: Name2 - name: Name21 the query expression { name => 'Name%2' } should only return 'Name2'. The current implementation returns both. This was implemented this way to ease the transition into the new code without changing too many things on the controller scripts. It is time to fix it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 19134] New: C4:: SMS does not handle drivers with more than two names well
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '17

01 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Bug ID: 19134 Summary: C4::SMS does not handle drivers with more than two names well Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org This code: 94 my $subpath = $driver; 95 $subpath =~ s|::|/|; is supposed to turn the "A::B" part of e.g. SMS::Send::A::B into "A/B", so it can be used as part of the path to the extra config file introduced in bug 13029. But it will only change the first occurence of :: into a /, so a driver with a name like SMS::Send::A::B::C will result in "A/B::C" being used as part of the path, which fails. A "g" modifier needs to be added to the regex, to do the substitution gloablly, thusly: 95 $subpath =~ s|::|/|g; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 9409] koha-create --request-db should be able to accept a dbhost option
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '17

01 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.

1 0