December 2017 - Koha-bugs - lists.koha-community.org

[Bug 19832] New: SIP checkout removes extra hold on same biblio
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832 Bug ID: 19832 Summary: SIP checkout removes extra hold on same biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: boutrosboutrosboutros(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com C4/SIP/ILS/Transaction/Checkout.pm includes the following bit of code which remove any hold that that matches the biblio and bilbionumber in checkout: # Fill any reserves the patron had on the item. # TODO: this logic should be pulled internal to AddIssue for all Koha. $debug and warn "pending_queue: " . (@$pending) ? Dumper($pending) : '[]'; foreach (grep {$_->{borrowernumber} eq $self->{patron}->{borrowernumber}} @$pending) { $debug and warn "Filling reserve (borrowernumber,biblionumber,reservedate): " . sprintf("(%s,%s,%s)\n",$_->{borrowernumber},$_->{biblionumber},$_->{reservedate}); ModReserveFill($_); # TODO: adjust representation in $self->item } As far as I can tell, this code is completely unnecessary, since C4::Circulation::AddIssue allread calls C4::Reserves::MoveReserve which fullfills the hold. What's more, if the borrower has multiple holds on the same biblio, all of them will be removed. This is clearly wrong. I purpose to remove the code above, unless someone can explain why SIP checkout should behave different than normal checkout in this case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 18114] New: koha-start-* and koha-stop-* should be replaced with the new command style
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 Bug ID: 18114 Summary: koha-start-* and koha-stop-* should be replaced with the new command style Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net Commands like koha-start-zebra and koha-stop-sip should be replaced with koha-zebra --start and koha-sip --stop to emulate the newer style used in script like koha-plack -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 17347] New: 'Renew' tab should ignore whitespace at begining and end of barcode
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347 Bug ID: 17347 Summary: 'Renew' tab should ignore whitespace at begining and end of barcode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you copy a barcode from somewhere else, sometimes there is whitespace at the beginning or the end. The checkout tab ignores this, the renew tab should as well. If you enter " validbarcode" the barcode is not found at the moment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 15894] New: Unify all account fine payment functions
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Bug ID: 15894 Summary: Unify all account fine payment functions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Right now, Koha has four different functions for making payments: recordpayment, makepayment, recordpayment_sellectaccts and makepartialpayment. We should replace these four functions with a single all-singing all-dancing method in the Koha::Namespace. This would help to reduce regressions and make future additions much simpler ( such as my planned re-implementation of account offsets ) and add consistency for logging and whatnot. -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 17045] New: Write API to Allow instant use of reports library
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '19

21 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17045 Bug ID: 17045 Summary: Write API to Allow instant use of reports library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: lisetteslatah(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Write an API that would allow us to select and run reports directly from the Koha Community Reports Library, as discussed at Koha US Conference 2016 during the reports Round table. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 18383] New: items.onloan schema comment seems to be incorrect.
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Bug ID: 18383 Summary: items.onloan schema comment seems to be incorrect. Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: pongtawat(a)punsarn.asia QA Contact: testopia(a)bugs.koha-community.org Currently the items.onloan schema comment (in SQL and hence on schema.koha-community.org too) is like this: defines if item is checked out (NULL for not checked out, and checkout date for checked out) However, on my installation (16.11.06), the date that Koha put into items.onloan column seems to be due date. So, probably the comment should be changed to: defines if item is checked out (NULL for not checked out, and due date for checked out) -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 19731] New: Notify when you add new item with reservations
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '19

19 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19731 Bug ID: 19731 Summary: Notify when you add new item with reservations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: patrick.robitaille(a)collecto.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Hi, It would be nice in Koha when you add a new item to have a notification or a pop-uo when all the items for this record are on loan and there are reservations for this record. That could be usefull to have this notification for the person who has added the new item to be niticed that it should be put on hold to satisfy reservations and not shelved with available status. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 16714] New: Unexpected logout with "IP address change"
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16714 Bug ID: 16714 Summary: Unexpected logout with "IP address change" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org I get a new issue (not sure since when) under Plack: I am logged out with "IP address change" just after the first login. To reproduce: - logout - restart plack - login - click somewhere => You will be logged out I have tried to debug: diff --git a/C4/Auth.pm b/C4/Auth.pm index 985bd39..a494ddf 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -818,6 +818,9 @@ sub checkauth { $userid = $s_userid; $sessiontype = $session->param('sessiontype') || ''; } + + warn $ip; + warn $ENV{REMOTE_ADDR}; if ( ( $query->param('koha_login_context') && ( $q_userid ne $s_userid ) ) || ( $cas && $query->param('ticket') && !C4::Context->userenv->{'id'} ) || ( $shib && $shib_login && !$logout && !C4::Context->userenv->{'id'} ) I get: After the login: $ip=undef, $ENV{REMOTE_ADDR}=192.168.254.1 After the click producing the logout: $ip=192.168.254.1, $ENV{REMOTE_ADDR}=127.0.0.1 After the second login: $ip=127.0.0.1, $ENV{REMOTE_ADDR}=127.0.0.1 -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 19701] New: Modify patron loses password in Microsoft Edge
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19701 Bug ID: 19701 Summary: Modify patron loses password in Microsoft Edge Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: Browser compatibility Assignee: oleonard(a)myacpl.org Reporter: emma.perks(a)heartofengland.nhs.uk QA Contact: testopia(a)bugs.koha-community.org In Microsoft Edge editing a patron record takes away the password and you have to add it back in before you can save the record. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 19816] New: output_pref must raised an exception if called with dateformat => rfc3339 and > dateonly => 1
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Bug ID: 19816 Summary: output_pref must raised an exception if called with dateformat => rfc3339 and > dateonly => 1 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 [Bug 18330] REST API: Date-time handling -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24