December 2017 - Koha-bugs - lists.koha-community.org

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #74 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #73) > QA Comment: > The POD statement is adjusted. Imo the POD should get some more attention. > No blocker. This is about the POD of IsAvailableForItemLevelRequest -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #73 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Thanks Alex for your perseverance. I am addressing your question from comment60 here too. Putting this on top of sec report 19319 which does some changes to Koha::Biblios->find in detail scripts. IsItemOnHoldAndFound is only used in CanBookBeRenewed and IsAvailableForItemLevelRequest; unfortunately it is not tested specifically. I think it should be moved to Koha::Item. And it should not call DBIx directly but use your search. The condition != undef is in practice the same as [W,T] since F is only used when the reserve is filled (finished) and moved to oldreserves. For the same reason I remove this test (using F in the reserves table does not reflect current use). Koha::Holds->find($hold->{reserve_id})->found('F')->store; $is = IsAvailableForItemLevelRequest( $item3, $borrower1); is( $is, 0, "Item is neither waiting nor in transit." ); See the followup patches. Rename hasItemswaitingOrInTransit => hasItemsWaitingOrInTransit ? No blocker. The POD statement is adjusted. Imo the POD should get some more attention. No blocker. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #72 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 69817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69817&action=ed… Bug 4319: (QA follow-up) Use ReservableItems in all scripts [1] Call CountItemsIssued or hasItemswaitingOrInTransit when needed only. [2] Add this logic to ISBD and MARC detail too, since they also use this include. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Confirming that Place hold now comes up if you have a waiting item and circulation rule == If any unavailable. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #71 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 69816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69816&action=ed… Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest [1] For consistency going back to IsItemOnHoldAndFound in this sub. This call is used in the on_shelf_holds == 2 case too. The routine will be refactored quite soon. Adding the else branch for on_shelf_holds == 0 for more clarity. [2] Removing the test for found==F in reserves. In Koha F is only used when the hold is filled and moved to oldreserves. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69724|0 |1 is obsolete| | Attachment #69728|0 |1 is obsolete| | --- Comment #70 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 69815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69815&action=ed… Bug 4319: [OPAC] Allow holds on waiting/transit items Test plan: - Checkout an item - Place hold on this item, - Return the item - Make sure the hold is waiting (found W) and AllowOnShelfHolds is not to 'Allow' - Check that the button "Place hold" appears in opac detail page of the biblio - do the samewith items/reserves in transit Changes on C4::Reserves::IsAvailableForItemLevelRequest Make sure this tests pass: - t/db_dependent/Reserves.t - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Rebased - 2017-12-12 - Alex Arnaud Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit Signed-off-by: Jon Knight <J.P.Knight(a)lboro.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19319 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19301 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #69 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here again -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don' t work as expected
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '17

15 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 jmbroust <jean-manuel.broust(a)univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes.

1 0