December 2017 - Koha-bugs - lists.koha-community.org

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #68 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- @Marcel: did you read my question on Comment 60 ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #67 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jon Knight from comment #66) > Ah, sorry it was a sign off from applying the bugs using git bz as normal, > so I'd not noticed it only included one. Should be a complete sign off. Thx. @Alex: I plan to resume QA on this one soon. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #66 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- Ah, sorry it was a sign off from applying the bugs using git bz as normal, so I'd not noticed it only included one. Should be a complete sign off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Jon Knight <J.P.Knight(a)lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #65 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- Ah, sorry it was a sign off from applying the bugs using git bz as normal, so I'd not noticed it only included one. Should be a complete sign off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #64 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jon Knight from comment #63) > Created attachment 69728 [details] [review] > Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit > > Signed-off-by: Jon Knight <J.P.Knight(a)lboro.ac.uk> Jon, For completeness: Did you intentionally sign off only the latest patch? Or is it meant as a complete signoff and did you forget to change status? Marcel -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Jon Knight <J.P.Knight(a)lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69725|0 |1 is obsolete| | --- Comment #63 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- Created attachment 69728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69728&action=ed… Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit Signed-off-by: Jon Knight <J.P.Knight(a)lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #62 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 69725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69725&action=ed… Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68786|0 |1 is obsolete| | --- Comment #61 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 69724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69724&action=ed… Bug 4319 - [OPAC] allow to holds waiting items Test plan: - Checkout an item - Place hold on this item, - Return the item - Make sure the hold is waiting (found W) and AllowOnShelfHolds is not to 'Allow' - Check that the button "Place hold" appears in opac detail page of the biblio - do the samewith items/reserves in transit Changes on C4::Reserves::IsAvailableForItemLevelRequest Make sure this tests pass: - t/db_dependent/Reserves.t - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Rebased - 2017-12-12 - Alex Arnaud -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '17

12 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #60 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #56) > It would be more consistent if we should use IsItemOnHoldAndFound in > IsAvailableForItemLevelRequest instead of a Koha::Holds->search. We actually > should adjust that routine. It does the same. Are we sure IsItemOnHoldAndFound does the same than Koha::Holds->search on W and T? What about a F status? Is it already used? Patch is coming for the others QA things -- You are receiving this mail because: You are watching all bug changes.

1 0