February 2017 - Koha-bugs - lists.koha-community.org

[Bug 13968] Branch email hints are misleading
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13968 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60432|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron(a)veron.ch> --- Created attachment 60531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60531&action=ed… Bug 13968 - Branch email hints are misleading This patch replaces missleading notes with Reply-To and Return-Path fields to reflect indicate falback values if they are empty (ReplyToDefault and ReturnpathDefault system prefs). To test: - Apply patch - In Home > Administration > Libraties and Groups, edit a library - Verify that hints display for fields Reply-To and Return-Path, indicating their default values. Amended to remove extra </li> - 2017-02-21 mv -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13968] Branch email hints are misleading
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13968 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mtompset(a)hotmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #19 from Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> --- I rebased the patches and now they apply properly. I removed the changes in the file C4/Accounts.pm since the sub makepartialpayment was moved and renamed to sub pay in Koha/Accounts.pm, the patch works fine with the new changes. I obsoleted the second patch which contained the tests for C4/Accounts.pm, because the module has it's own test files. I added a test plan everyone can test it. Test Plan 1) Apply patch 2) Select a patron with a fine. 3) Go to the selected details patron. 4) Go to the fines tab. 5) Click the button pay amount or pay selected. 6) Choose the amount paid equal to the outstanding amount(exemple : 3$). 7) Choose the amount collected to be more than the outstanding amount(exemple :5$) 8) Click the button confirm. - You should be prompted with a message saying : "Change to give back: 2.00" 9) Click on the button above Confirm payment. The selected patron should not have an outstanding fines left. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Assignee|pasi.kallinen(a)pttk.fi |baptiste.wojtkowski@biblibr | |e.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28455|0 |1 is obsolete| | --- Comment #4 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 60530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60530&action=ed… BUG 12310 : Modified scripts in order to convert any string to the good format paxed's solution is obsolete since the form asks for a number. The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All spaces (before or after) are ignored. Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) 2) Apply patch 3) Check you can enter any string with - $, "Euro" (before or after), or nothing - , or . as separator - no more than 2 digits after separator - as much digits as you wish before the separator - as much spaces as you wish before or after the number -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13968] Branch email hints are misleading
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13968 --- Comment #2 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 60432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60432 Bug 13968 - Branch email hints are misleading Review of attachment 60432: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=139…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt @@ +186,5 @@ > <li><label for="branchphone">Phone: </label><input type="text" name="branchphone" id="branchphone" size="60" value="[% library.branchphone |html %]" /></li> > <li><label for="branchfax">Fax: </label><input type="text" name="branchfax" id="branchfax" size="60" value="[% library.branchfax |html %]" /></li> > <li><label for="branchemail">Email: </label><input type="text" name="branchemail" id="branchemail" class="email" size="80" value="[% library.branchemail |html %]" /></li> > + <li><label for="branchreplyto">Reply-To: </label> <input type="text" name="branchreplyto" id="branchreplyto" class="email" size="80" value="[% library.branchreplyto |html %]" /><br /><span class="hint"></hint>Default: ReplyToDefault system preference</li> > +</li> Extra </li>? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #18 from Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> --- Created attachment 60529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60529&action=ed… Bug 11373 - Fixed: 'Change to give back' not displaying. I tested the last patch and found that the case 'amount oustanding == amount paid' was not handled in paycollect.p . The confirmation box should now appear when those values are equal and the amount collected is higher than the amount paid. I have found another problem while testing. When paying all fines or selected fines, the 'The amount collected is greater than the total amount paid.' message would appear even when the entered data was correct. Both issues were adressed in this patch. modified: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt modified: members/paycollect.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36875|0 |1 is obsolete| | Attachment #36876|0 |1 is obsolete| | Attachment #36877|0 |1 is obsolete| | --- Comment #17 from Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> --- Created attachment 60528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60528&action=ed… Bug 11373: Add a "cash register" feature to the fine payment form. If the amount received is greater than the amount to pay, a message is shown to tell the employee how much money to give back. Signed-off-by: Joel Aloi <aloi54(a)live.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '17

21 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi(a)inlibro.com -- You are receiving this mail because: You are watching all bug changes.

1 0