February 2017 - Koha-bugs - lists.koha-community.org

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '17

13 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7534, 18072 Status|NEW |Needs Signoff --- Comment #9 from Lari Taskula <lari.taskula(a)jns.fi> --- I have posted some patches for my proposed solution to be tested in OPAC. Please apply Bug 7534 and Bug 18072 before applying these patches. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 [Bug 18072] Add Koha objects for Branch Transfer Limits -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '17

13 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #8 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60145&action=ed… Bug 7614: Build a list of pickup locations in OPAC considering transfer limits This patch enables the checks for transfer limits for given biblionumber in OPAC when patron proceeds to place a hold. In case none of the items of that biblio can be transferred to a library, that library will not be included in the list of pickup locations. To test: 1. Make sure you meet the following requirements: 1.1: You are able to make holds in OPAC 1.2: System preference UseBranchTransferLimits set to "Enforce" 1.3: System preference BranchTransferLimitsType set to "item type" (for the sake of simplicity of this test plan, but you may also set it to "collection code" and deal with ccodes instead) 1.4: System preference item-level_itypes set to "specific item" 1.5: You have the default libraries and item types, otherwise replace the branchcodes and itemtypes in this test plan with your own 2. Make sure 'Fairfield' in cgi-bin/koha/admin/branches.pl has not disabled its ability to act as a "Pickup location" 3. Have a biblio with exactly one item of item-level itemtype 'BK' 4. Set item holdingbranch as 'CPL' 5. Go to cgi-bin/koha/admin/branch_transfer_limits.pl (keep this page open in a second tab for faster testing) 6. Select library 'Centerville' 7. Uncheck the checkbox 'FFL - Fairfield' and click Save 8. Go to OPAC and find your biblio, and start placing a hold on it 9. Click at the list of "Pick up location"s. 10. Observe that it is missing 'Fairfield' 11. Go back to cgi-bin/koha/admin/branch_transfer_limits.pl 12. Repeat step 6 and this time, check the checkbox 'FFL - Fairfield' 13. Refresh the page you arrived at step 8 14. Observe that it now includes 'Fairfield' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '17

13 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #7 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60144&action=ed… Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches Consider transfer limits in Koha::Template::Plugin::Branches->pickup_locations. This patch modified the mentioned method to consider branch transfer limits and does not include any library in the returned list of libraries in case a branch transfer limit applies for a given book or item. To be tested in following patches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '17

13 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #6 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60143&action=ed… Bug 7614: Check branch transfer limits in opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '17

13 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #5 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60142&action=ed… Bug 7614: Check transfer limit in CanBookBeReserved and CanItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. This patch checks if the library is configured to be a pickup location (see Bug 7534), and also if the item can be transferred into the given library (see Bug 18072). To test: 1. prove t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '17

13 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #4 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60141&action=ed… Bug 7614: Add a new method Koha::Libraries->pickup_locations This patch adds a new method, Koha::Libraries->pickup_locations. This method takes either an item or a biblio as a parameter, and returns the list of acceptable pickup locations by considering libraries' configuration to act as a pickup location as well as any branch transfer limits that may apply. To test: 1. prove t/db_dependent/Koha/Libraries.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13685] Sorting Patron Reading History
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '17

12 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59956|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 60134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60134&action=ed… Bug 13685: Sorting by author in opac reading history To test: 1) Log into OPAC, go to your raeding history 2) Notice 'author' is in Title column, therefore unable to sort by author 3) Apply patch and refresh page 4) Notice author has now been moved into Author column 5) Confirm sorting by author works as expected and sorting of all other columns works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13685] Sorting Patron Reading History
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '17

12 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13685] Sorting Patron Reading History
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '17

12 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #9 from M. Tompsett <mtompset(a)hotmail.com> --- Might I also recommend doing the same kind of split for the summary page too? Not that affects this bug, but it might be another one to think about. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11450] Hold Request Confirm Deletion
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '17

12 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- As Owen pointed out, this pattern is still standard in Koha. As this is a bugfix, can we continue discussion about future style changes on a separate bug and have this go in? -- You are receiving this mail because: You are watching all bug changes.

1 0