March 2017 - Koha-bugs - lists.koha-community.org

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Colin Campbell <colin.campbell(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54827|0 |1 is obsolete| | --- Comment #18 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- Created attachment 61738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61738&action=ed… Patch rebased Patch rebased against master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #56 from David Gustafsson <glasklas(a)gmail.com> --- Ops, wrong copy paste. Fixed missing "String::Similarity" include in Biblio.pm, and changed $filter argument in ModBiblio to more flexible $options to avoid future merge conflicts and provide a more stable API. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #55 from David Gustafsson <glasklas(a)gmail.com> --- As another criticism, some of the things that should be easy are not, in particular, Server-Side Rendering. Ember’s implementation of SSR requires two simple entries on the command-line. Vue’s requires a simple wrapper around standard objects. AngularJS’ implementation is honestly kind of awful but at least well documented with a whole dedicated sub-site. This is Meteor’s implementation: ¯\_(ツ)_/¯ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61641|0 |1 is obsolete| | --- Comment #54 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 61736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61736&action=ed… Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #59 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Patch above fix Marcel's QA comments. Also, i added some minor changes: in the sub Koha::Hold::set_waiting: => Remove the test "if ( C4::Context->preference("ExpireReservesMaxPickUpDelay") )". I think we want to calculate the expiration date even if ExpireReservesMaxPickUpDelay is set to dont't allow in C4::Reserves::CancelExpiredReserves: return if ExpireReservesMaxPickUpDelay is set to don't allow. Do nothing turn this BZ back to Signed off status. Tell me if the changes make i should pass it to Needs Signoff again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #58 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 61735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61735&action=ed… Bug 12063 - Fix QA failures - Remove expiration date calculation in C4::Letter since it's done when setting the reserve waiting, - remove expiration date calculation in circ/waitingreserves.pl. Use the one in DB, - add a new atomic update that calculate expiration date for waiting reserves, - add tests for days_foward function and fix the infinite loop. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 --- Comment #11 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Hi, Working on mine, did you follow a testplan like this one ? And I'm surprized about all tests being fine, because the test about budget is supposed to be false : checkout all file except test 1 - go on mysql "select * from aqbudgets \G" 2 - duplicate a budget 3 - "select * from aqbudgets \G" => new budgets should have the same timestamp as the others 4 - apply patch 5 - "select * from aqbudgets \G" => new budget have new timestamp Errors I think you can have done testing my patch: - look at aqbudgetperiods - look at the date of creation or enddate and not timestamp -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10357] Send email when serial received subscription link is hard to find
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18350 Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10357] Send email when serial received subscription link is hard to find
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61724|0 |1 is obsolete| | --- Comment #13 from Marc Véron <veron(a)veron.ch> --- Created attachment 61726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61726&action=ed… Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' link 5) Confirm this link still works as expected Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '17

30 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha(a)catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #10 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- All tests pass but a new timestamp is still not being generated. Setting to Failed QA. -- You are receiving this mail because: You are watching all bug changes.

1 0