March 2017 - Koha-bugs - lists.koha-community.org

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #8 from Eric <eric.gosselin.5(a)gmail.com> --- (In reply to Eric from comment #7) > Patch didn't apply in the sandboxes. Auto-merging koha-tmpl/intranet-tmpl/prog/js/cataloging.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/addbiblio.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/addbiblio.css Auto-merging cataloguing/addbiblio.pl Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm Patch failed at 0001 Bug 14367: Add MARC record history The copy of the patch that failed is found in: .git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #127 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61575&action=ed… Bug 13757: (QA followup) Filter out non-editable params before storing Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #126 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61574&action=ed… Bug 13757: (QA followup) Exclude empty attributes from rendering if non-editable In self registration opac displayable (and not editable) attributes are displayed as empty. This an empty value is passed to the template for creating an empty input and it shouldn't when the attribute is not editable. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #125 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61573&action=ed… Bug 13757: Attribute with value 0 should be stored Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #124 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61572&action=ed… Bug 13757: (regression test) Attribute with value 0 should be stored Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #123 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61571&action=ed… Bug 13757: Better display for attr changes in members-update.pl This patch changes the way changed attributes are displayed for the staff user to make the decision to approve (or not) the changes. Regards Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #122 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61570&action=ed… Bug 13757: Make K::P::Modifications->pending return K::P::Attribute This patch makes Koha::Patron::Modifications->pending return Koha::Patron:Attribute objects. They are not stored on the DB but only live in memory on runtime. members-update.pl is the only place this is used, and this way we have all we need for better rendering the UI. Tests are added for the changed API. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #121 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61569&action=ed… Bug 13757: (QA followup) Fix non-editable attrs on failed save When a field is not editable but displayable in the OPAC, and you submit an incomplete/wrong update, those attributes are displayed as empty. This patch fixes that. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Eric <eric.gosselin.5(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |eric.gosselin.5(a)gmail.com --- Comment #7 from Eric <eric.gosselin.5(a)gmail.com> --- Patch didn't apply in the sandboxes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #120 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61568&action=ed… Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion The original code on this bug skipped empty-valued attributes. But emptying attributes is the only way to tell the controller script that the user wants to delete them. This patch makes opac-memberentry.pl check the existence of attributes sharing the code of the empty for the given patron, and it stores the deletion on the Koha::Patron::Modification as needed. Otherwise deletions got skipped. To test: - Verify setting/deleting attributes that are opac-editable and verify the results are sound. https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0