March 2017 - Koha-bugs - lists.koha-community.org

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #92 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61140&action=ed… Bug 13757: (followup) Regression tests for ->approve changes Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #91 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61139&action=ed… Bug 13757: (followup) Only touch opac_editable attributes As reported by Owen, the members-update.pl was showing every attributes the patron has (display issue) instead of showing only those affected by the changes. This patch fixes this by filtering the patron's attributes by opac editability. It also fixes Koha::Patron::Modification->approve so it only clears the attributes with the updating 'code' and leaves the others untouched. As its been coded so far (until someone refactors it all) the Koha::Patron::Modification object needs to contain all the attributes for a specific code. And it comes from parsing the UI's input. Tests for Koha::Patron::Modification->approve to come. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #90 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61138&action=ed… Bug 13757: (followup) Staff interface changes This patch adds proper extended attributes display and handling on the patron modifications moderation page (members-update.pl). It also adds changes checking to the opac-memberentry.pl page so it only saves a modification request if there are changes (it only checked regular fields and not the extended ones). Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #89 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61137&action=ed… Bug 13757: (followup) Remove warnings Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #88 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61136&action=ed… Bug 13757: Add extended attributes to the patron modification Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #87 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61135&action=ed… Bug 13757: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #86 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61134&action=ed… Bug 13757: OPAC changes Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #85 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61133&action=ed… Bug 13757: DB update Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58706|0 |1 is obsolete| | Attachment #58707|0 |1 is obsolete| | Attachment #58708|0 |1 is obsolete| | Attachment #58709|0 |1 is obsolete| | Attachment #58710|0 |1 is obsolete| | Attachment #58711|0 |1 is obsolete| | Attachment #58712|0 |1 is obsolete| | Attachment #58713|0 |1 is obsolete| | Attachment #58714|0 |1 is obsolete| | Attachment #58715|0 |1 is obsolete| | Attachment #59376|0 |1 is obsolete| | Attachment #59737|0 |1 is obsolete| | Attachment #59738|0 |1 is obsolete| | Attachment #59739|0 |1 is obsolete| | Attachment #59896|0 |1 is obsolete| | Attachment #59897|0 |1 is obsolete| | Attachment #59898|0 |1 is obsolete| | Attachment #60359|0 |1 is obsolete| | Attachment #60360|0 |1 is obsolete| | --- Comment #84 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 61132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61132&action=ed… Bug 13757: Add the option to set patron attributes editable in the OPAC Note: this is a squashed version of the original patchset, because it was needed This patch adds an opac_editable property of borrower attribute types that can be set in the interface. I'm removing work on OPAC and will refactor it, keeping the author attribution. Test plan: 1. Repeat the following with a new and existing borrower attribute type: 2. Verify that "Editable in OPAC" can only be checked if "Display in OPAC" is checked. 3. Verify that this new property is correctly saved. Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '17

15 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0