March 2017 - Koha-bugs - lists.koha-community.org

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61045|0 |1 is obsolete| | --- Comment #41 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 61047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61047&action=ed… Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl To test: -1. Have access to your browser's developer tools in order to modify <select> dropdown values 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No". Remember the branchcode of this library! 3. Go place a hold in OPAC 4. See the provided "Pick up location" list 5. Observe the library that you configured is not present in the list 6. You should see another library selected by default. Right click that and in Firefox/Chrome click "Inspect element" 7. You should see a list of <option value="xxxx">blabla</option> elements 8. Double click between value (xxxx in above example) and replace the value with the branchcode you remember from step 2. 9. Place the hold 10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold was not successful. 11. Go back to place a hold and this time do not modify any values. 12. Observe that a hold is now placed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61044|0 |1 is obsolete| | --- Comment #40 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 61046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61046&action=ed… Bug 7534: Validate pickup location in CanBook/ItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. To test: 1. prove t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #39 from Lari Taskula <lari.taskula(a)jns.fi> --- (In reply to Jonathan Druart from comment #36) > Lari, I think we need a check server-side to make sure a patron will not > inject a library that is not in the list. Agreed. This was done in Bug 7614, but as it should be already in this Bug, I took the patches from 7614 and rewrote them to be suitable in 7534. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #38 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 61045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61045&action=ed… Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl To test: -1. Have access to your browser's developer tools in order to modify <select> dropdown values 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No". Remember the branchcode of this library! 3. Go place a hold in OPAC 4. See the provided "Pick up location" list 5. Observe the library that you configured is not present in the list 6. You should see another library selected by default. Right click that and in Firefox/Chrome click "Inspect element" 7. You should see a list of <option value="xxxx">blabla</option> elements 8. Double click between value (xxxx in above example) and replace the value with the branchcode you remember from step 2. 9. Place the hold 10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold was not successful. 11. Go back to place a hold and this time do not modify any values. 12. Observe that a hold is now placed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #37 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 61044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61044&action=ed… Bug 7534: Validate pickup location in CanBook/ItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. To test: 1. prove t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Lari Taskula <lari.taskula(a)jns.fi> --- (In reply to Koha Team AMU from comment #13) > I tried to test in sandbox but failed : Hi and thanks for testing! This patch set is not rebased yet on top of Bug 7534 as it is currently going through some changes in QA process. I will rebase these patches once Bug 7534 passes QA. (In reply to Olli-Antti Kivilahti from comment #14) > Created attachment 60938 [details] [review] > Bug 7614 - Fix my variable earlier declaration bug. (In reply to Olli-Antti Kivilahti from comment #15) > Created attachment 60946 [details] [review] > Bug 7614 - Fixes "Looks like you planned 61 tests but ran 62" at > t/db_dependent/Holds.t Thanks Olli-Antti! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15449] Move stuffs to the Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18252 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Bug 18252 - Move C4::Items code to the Koha namespace Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 --- Comment #8 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- On further inspection, it appears that in 3.22.8, issues.date_due shows the date but not the time. In master, I see that issues.date_due includes the time as well. Can't find the bug that changed this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 --- Comment #7 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to Katrin Fischer from comment #6) > I did some more tests - this problem appears in 3.18.6, but is fixed on the > current 3.18.x branch, that will be 3.18.7. Katrin, Please confirm with master. I am in 3.22, and I see that issues.date_due is producing a date, but I do not see a time stamp. Shouldn't this value produce a timestamp for hourly loans, or do hourly loans have to be turned on in order for it to produce a time stamp? Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '17

13 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Lari, I think we need a check server-side to make sure a patron will not inject a library that is not in the list. -- You are receiving this mail because: You are watching all bug changes.

1 0