March 2017 - Koha-bugs - lists.koha-community.org

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #24 from Lari Taskula <lari.taskula(a)jns.fi> --- Changed pickup_location column type to TINYINT(1) since that's what we generally use for "booleans" and added it to kohastructure.sql (forgot to add it there before!) (In reply to Chris Kirby from comment #17) > I don't get the "internal server error" on an old ubuntu system (14.04 LTS) > but I DO get it on kohadevbox with a Windows host and Debian Jessie guest. > > On the Kohadevbox, Debian Jessie, > koha-plack-err: > Template process failed: undef error- The method pickup_location is not > covered by tests! at /usr/share/koha/lib/C4/Templates.pm line 121. Sent you a message on IRC! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #23 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60799&action=ed… Bug 7534: Add pickup_location to kohastructure.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60781|0 |1 is obsolete| | --- Comment #22 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60798&action=ed… Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl This patch sets opac-reserve.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go to OPAC and place a hold 4. See the provided Pickup location list 5. Observe the library that you configured is not present in the list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60023|0 |1 is obsolete| | --- Comment #21 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60797&action=ed… Bug 7534: Display pickup locations instead of all libraries in request.pl This patch sets request.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go place a hold in intranet 4. See the provided "Pickup at" list 5. Observe the library that you configured is not present in the list 6. Place the hold 7. See list of existing holds on that biblio 8. See "Pickup library" column and observe your configured library is not included in the list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60016|0 |1 is obsolete| | --- Comment #20 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60796&action=ed… Bug 7534: Add configuration to admin/branches.pl This patch adds a configuration option for pickup locations. To test: 1. Apply patch 2. Go to cgi-bin/koha/admin/branches.pl 3. Observe there is a new column "Pickup location" 4. Click "Edit" for any library 5. Scroll to bottom of the page and select "No" 6. Click "Submit" 7. Observe your library in Libraries-table, notice the value of "Pickup location" has changed to "No" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60015|0 |1 is obsolete| | --- Comment #19 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60795&action=ed… Bug 7534: Add method Koha::Template::Plugin::Branches->pickup_locations This patch adds a new method Koha::Template::Plugin::Branches->pickup_locations. Unit tests included. To test: 1. prove t/db_dependent/Template/Plugin/Branches.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60014|0 |1 is obsolete| | --- Comment #18 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 60794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60794&action=ed… Bug 7534: Add new column "pickup_location" to branches This patch adds a new column "pickup_location" for each library. This value defines whether a library can be used as a pickup location or not. For extended configurability, this flag could perhaps be considered as a part of issuing rules, but as of now, this patch only offers a simple flag into each library. This method also allows easy way for REST API to determine valid pickup locations by querying the /libraries endpoint. To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Observe DEV atomic update: bug_7534.perl Upgrade to XXX done (Bug 7534 - Let libraries have configuration for pickup locations) https://bugs.koha-community.org/show_bug.cgi?id=7354 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12836] SRU Explain file needs to be rewritten
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 --- Comment #10 from Magnus Enger <magnus(a)libriotech.no> --- My patch does not take into account the need for per-instance Explain docs. That will have to be a separate bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12836] SRU Explain file needs to be rewritten
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60732|0 |1 is obsolete| | --- Comment #9 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 60791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60791&action=ed… Bug 12836 - Add script to rewrite SRU Explain file The standard SRU Explain files provided with Koha is static and out of date. This patch does two things - Add a script in misc/maintenance/generate_explain.pl that can generate a new Explain file, based on Koha's config files and an optional extra config file. See the POD in the script for more details. - Replace the old Explain files provided with Koha with two new files, generated by the script described above and based on the standard Koha/Zebra config. To test: - Have a look at etc/zebradb/explain-authorities.xml and etc/zebradb/explain-biblios.xml and see if they make sense as example files. Check that the list of indexes corresponds to the indexes set up in etc/zebradb/pqf.properties. - Run "perldoc misc/maintenance/generate_explain.pl" to see available options and a decription of the config file. - Run generate_explain.pl with different options and settings in the config file, and check that the output Explain docs make sense. This patch will not break anything. It is more about documentation. The Explain file documents the SRU server, it does not configure it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12836] SRU Explain file needs to be rewritten
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '17

02 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0