May 2017 - Koha-bugs - lists.koha-community.org

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #76 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 63695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63695&action=ed… Bug 12904 - Add mod_expire to etc/koha-httpd.conf Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #75 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 63694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63694&action=ed… Bug 12904 [QA Followup] - Don't send 301 status Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #74 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 63693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63693&action=ed… Bug 12904 - Update template css and js file references Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60826|0 |1 is obsolete| | Attachment #60827|0 |1 is obsolete| | Attachment #60830|0 |1 is obsolete| | Attachment #60831|0 |1 is obsolete| | --- Comment #73 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 63692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63692&action=ed… Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #72 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- (In reply to Martin Renvoize from comment #71) > I came here to QA this, then realised I wrote a bunch of the original code > that was eventually rebased. > > This is still a great thing to have and we've been using it in production in > a few places so I'm happy it works. > > I'll try to find a friendly QAer. Just QA this plix? PM when you plan to do so. This is a big moving target and it is hard to keep it applying to master. We have a rebased version from two-three weeks ago I guess. No point in wasting time applying it here because it will just get stale. While doing that I can rebase our fork on top of master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1993] Task Scheduler Needs Re-write
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Lucy Vaux-Harvey <lucy.vaux-harvey(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mjr(a)software.coop |mtompset(a)hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function
by bugzilla-daemon＠bugs.koha-community.org 24 May '17

24 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 --- Comment #5 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 63681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63681 Bug 5395: Update C4::Acquisition::SearchOrders POD Review of attachment 63681: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=539…) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ -1656,4 @@ > @results = &SearchOrders({ > ordernumber => $ordernumber, > search => $search, > - biblionumber => $biblionumber, Moved to match the code order of grabbing parameters, to make comparison easier. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0