May 2017 - Koha-bugs - lists.koha-community.org

[Bug 11425] Search form for items
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18633 --- Comment #72 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- See bug 18633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633 [Bug 18633] Logs are full of CGI::param called in list context - itemsearch.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11425] Search form for items
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #71 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- The use of the CGI TT plugin floods logs with: itemsearch.pl: CGI::param called in list context from package Template::Document line 118, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl Julian, can you check how we can fix that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 63540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63540&action=ed… Bug 11122: Follow up - Fix some display issues and typos This patch fixes the display of copyrightdate for MARC21 installations. As MARC21 already requires you to add punctuation in cataloguing, there is usually no need for punctutation in the templates. Also fixes a template variable name typo and the basket summary page. To test (all 3 patches): - Add several order lines to an order, one should be uncertain - Verify that the publisher and publication year are displayed - Check the uncertain price page - Verify that the publisher code and publication year are displayed - Fix uncertain price and close your order - Basket summary: Verify... (you know what) - Cancel one of your orders - Verify... for cancelled orders - Receive shipment - Verify... for unreceived orders - Receive order - Verify ... for received orders - Finish receiving - Verify ... on the invoice summary page Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 63539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63539&action=ed… Bug 11122: Address MARC21 vs. UNIMARC issue In comment #6 and comment #17, Katrin pointed out the discrepancy between UNIMARC (using publisheryear) vs. Other MARC installations (using copyrightdate). This was dealt with in invoice.tt already. This patch does similar logic for the other 3 template files. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63405|0 |1 is obsolete| | Attachment #63406|0 |1 is obsolete| | Attachment #63407|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 63538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63538&action=ed… Bug 11122 - publisher code and publication year not fetched in acq orders In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt. Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails. The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear. In uncertainprice.pl those datas are fetch using GetBiblioData. It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume. This patch also unifies the way biblio datas are displayed : <a href="link to catalog using biblionumber">[title]</a> <em>by</em> [author] – [isbn] <em>Publisher:</em> [publishercode], [publicationyear] Test plan : - Choose a biblio record containing a data in : biblio.title, biblio.author, biblioitems.isbn, biblioitems.publishercode, biblioitems.publicationyear, biblio.seriestitle, biblioitems.volume. - Create an order using this biblio. - Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl => You see publisher code and publication year - Look at this order in page : invoice.pl => You see publisher code, publication year, series title and volume Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |oliver.bock(a)aei.mpg.de CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63410|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 63537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63537&action=ed… Bug 14625 - LDAP: skip extended patron attributes in 'borrowers' attribute update * Any extended patron attributes will cause the update to fail as those attributes don't exist in the 'borrowers' table * The update of the extended patron attributes is already dealt with in checkpw_ldap() * Ergo: just skip those attributes here Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> I did not test this patch but code looks good -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 18 May '17

18 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #30 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I do not like the way this bug is fixed (especially the drop of the FK). I will not oppose to a push as I do not have anything else to suggest. I let the QA step to someone else. -- You are receiving this mail because: You are watching all bug changes.

1 0