May 2017 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #50 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 63472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63472&action=ed… Bug 7317: Bugfix: remove `my` statements. * Koha/Illrequest.pm (available_backends): Remove incorrect `my` statements for @backends variable. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #49 from Magnus Enger <magnus(a)libriotech.no> --- +sub available_backends { + my ( $self ) = @_; + my $backend_dir = $self->_config->backend_dir; + my @backends = (); + my @backends = <$backend_dir/*> if ( $backend_dir ); + my @backends = map { basename($_) } @backends; + return \@backends; +} This gives a warning: "my" variable @backends masks earlier declaration in same scope at /path/to/Koha/Illrequest.pm line 375. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15449] Move stuffs to the Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 [Bug 18606] Move rotating collections code to Koha::Object -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17324] New: branchcode is NULL in letter triggers red upgrade message
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 Bug ID: 17324 Summary: branchcode is NULL in letter triggers red upgrade message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I suspect there is probably relevant discussion on bug 14839. However, I just want a clean upgrade for MySQL 5.7 on Ubuntu 16.04 LTS. [Tue Sep 20 19:08:10 2016] updatedatabase.pl: DBD::mysql::db do failed: Invalid use of NULL value [for Statement " [Tue Sep 20 19:08:10 2016] updatedatabase.pl: ALTER TABLE letter MODIFY COLUMN branchcode varchar(10) NOT NULL DEFAULT '' [Tue Sep 20 19:08:10 2016] updatedatabase.pl: "] at /home/mtompset/kohaclone/installer/data/mysql/updatedatabase.pl line 12638. Reproduce: on an ubuntu 16.04 LTS machine with MySQL 5.7 install git koha development environment. ... git checkout -b my_3.18.x origin/3.18.x drop database koha_library; create database koha_library; quit; web install all sample data (ignore some issues with sample data, and one with mandatory) git checkout -b bug_17234 origin/master git bz apply 17292 git bz apply 17320 git bz apply 17260 git bz apply 17234 web install Two warning messages are expected output from upgrade process, but the above message is not. repeat the above, but git bz apply this patch before running the second web install. The message should be not there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 17260] New: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 Bug ID: 17260 Summary: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: philippe.blouin(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org See also Bug 17234 The loading of file admin/searchengine/elasticsearch/mappings.yaml specifies 'type' as empty, which fails with Mysql 5.7+ which is more stringent. Also, forcing an empty value into a boolean also fails. Both issues arise when updatedatabase.pl hit 3.23.00.050. -- You are receiving this mail because: You are watching all bug changes.

1 28

[Bug 17813] New: Table borrower_attributes needs a primary key
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Bug ID: 17813 Summary: Table borrower_attributes needs a primary key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In order to be used correctly on DBIC the table needs a primary key. Otherwise calls to ->delete would fail. -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Bug 14187 depends on bug 17234, which changed state. Bug 17234 Summary: ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17914] New: The installer process tries to create borrowers.updated_on twice
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17914 Bug ID: 17914 Summary: The installer process tries to create borrowers.updated_on twice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17234, 10459 Bug 10459 has been backported and the DB entry (add borrowers.updated_on and deletedborrower.updated_on) is now played in - 16.06.00.027 - 16.05.00.002 - 3.22.08.001 This will raise a MySQL warning if the column already exists. DBD::mysql::db do failed: Duplicate column name 'updated_on' Since bug 17234 we have now a subroutine (C4::Installer::column_exists) to test if a column exists. When a DB entry modifying the DB structure is backported, it HAS TO check if the column, constraint or table exists before executing the query. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 [Bug 10459] borrowers should have a timestamp https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 17356] New: Add atomic update .perl skeleton file
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Bug ID: 17356 Summary: Add atomic update .perl skeleton file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 14399] Fix inventory.pl part two (following 12913)
by bugzilla-daemon＠bugs.koha-community.org 15 May '17

15 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

1 0