May 2017 - Koha-bugs - lists.koha-community.org

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- On second thoughts, as update_local isn't currently tested at all I think perhaps it widens the scope a bit too much to expect you to write the tests. I'll open another bug to write the tests for the whole of update_local and hopefully I'll get around to writing them this century! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #12 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I've signed off the proposed patch, but marked the overall bug as failed qa untill we have test coverage. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63410|Bug 14625 - LDAP: skip |[SIGNED OFF] Bug 14625 - description|extended patron attributes |LDAP: skip extended patron |in 'borrowers' attribute |attributes in 'borrowers' |update |attribute update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #11 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 63410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63410&action=ed… Bug 14625 - LDAP: skip extended patron attributes in 'borrowers' attribute update * Any extended patron attributes will cause the update to fail as those attributes don't exist in the 'borrowers' table * The update of the extended patron attributes is already dealt with in checkpw_ldap() * Ergo: just skip those attributes here Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 12 May '17

12 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #10 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Code looks sane and does the trick.. but we'll need an update to the unit tests to cover the change before it'll get past QA. Oliver, are you happy to have a go at adding a test to Auth_with_ldap.t? -- You are receiving this mail because: You are watching all bug changes.

1 0