June 2017 - Koha-bugs - lists.koha-community.org

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18723 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10267] No error message when entering an invalid cardnumber
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr --- Comment #17 from Séverine Queune <severine.queune(a)bulac.fr> --- Tested on BibLibre's sandbox #2 The patch applies as described in Comment #13. However, now there is a new patch for bug 13178 and it is not taken in count in the current bug, I don't know if I'm supposed to sign it :/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr Status|Needs Signoff |Failed QA --- Comment #10 from Séverine Queune <severine.queune(a)bulac.fr> --- Tested on the BibLibre's sandbox #2. Behavior is exactly the same for staff client and OPAC : - Display is correct for the button "First" : it not visible when you're on the first page (neither button "<< Previous"); using it brings you back to the first page. - I had more difficulties with button "Last" (expect explanations will be clear...): > Using the button "Last" didn't always bring me to the last page (I arrived page 167 instead of 174 // for only 2 pages result, I arrived on a blank page // it was ok for a result with 18 pages) > I had problem on the number of the pages : after clicking on "Last", all the pages were named "[page_number].[number]" : I searched different keywords and the number after the dot was always different (.05 ; .25 ; .18). When I went to the last pages without using the button "Last", the numbers appear correctly. > on the last page, both buttons "Last" and "Next" appear once I used one of them. Display is correct (none of them visible) when I went to the last page not using "Last" but jumping for one page to another until the last one. I agree with Katrin about a box to enter the page we want to go to. I also think it would be useful to have on staff client the pagination appearing both at the top and the bottom of the page result (like it is on the OPAC). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13208] More complete breadcrumbs when cancelling an order
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #4 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 64697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64697&action=ed… Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13208] More complete breadcrumbs when cancelling an order
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13208] More complete breadcrumbs when cancelling an order
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes(a)biblibre.com --- Comment #3 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by severine.queune <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13208] More complete breadcrumbs when cancelling an order
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |severine.queune(a)bulac.fr --- Comment #2 from Séverine Queune <severine.queune(a)bulac.fr> --- The patch applies correctly : breadcrumbs is complete and both links to vendor and basket work. 'Aquisitions' is now ended by an 's'. Thanks Aleisha ! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64679|0 |1 is obsolete| | --- Comment #31 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 64696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64696&action=ed… Bug 12310 : Modify scripts in order to convert any string to the good format paxed's solution is obsolete since the form asks for a number. The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All other symbols are ignored. Modify the tooltips helping the users entering monrtary information in the right format. Fields on all those pages are now automatically formatted - cgi-bin/koha/admin/aqbudgetperiods.tt - cgi-bin/koha/admin/aqbudgets.tt - cgi-bin/koha/members/mancredit.tt - cgi-bin/koha/members/maninvoice.tt Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) - you pay an existing fine 2) Apply patch 3) Check you can enter any string with - anything you want - a , or a . as separator (both are default) - change the syspref DigitSeparator into the separator you with and check again ex : XXX,XXX,XXX.XX => . XXX XXX XXX,XX => ,. or , XXX XXX XXX.XX => ,. or . The string is immediately changed after you change the field Please note that any other symbole is ignored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '17

28 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #29 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 64693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64693&action=ed… Bug 14385: Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. -- You are receiving this mail because: You are watching all bug changes.

1 0