June 2017 - Koha-bugs - lists.koha-community.org

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #57 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64226&action=ed… Bug 14826 - Add offset for rental fees Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #56 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64225&action=ed… Bug 14826 - Add new offset table schema file Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #55 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64224&action=ed… Bug 14826 - Remove old offset table schema file Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #54 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64223&action=ed… Bug 14826 - Unit Tests Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #53 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64222&action=ed… Bug 14826 - Resurrect account offsets table The account offsets table should be used to track increments and decrements of fines via payments and credits, as well as fine accruals. It should be able to match fees to payments and visa versa, so we can know which fee was paid by a given payment, and which payments applied to a given fee. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Note the table accountoffsets has been renamed to account_offsets 4) Ensure fine generation creates offsets 5) Ensure creating a manual invoice creates an offset 6) Ensure a lost item charge creates an offset 7) Ensure Reverse Payment creates an offset 8) Ensure a payment creates an offset 9) Ensure a payment for multiple fees creates an offset for each 10) Ensure writeoffs create offsets Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #52 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64220&action=ed… Bug 14826 - Add Koha modules for offsets Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64051|0 |1 is obsolete| | Attachment #64052|0 |1 is obsolete| | Attachment #64053|0 |1 is obsolete| | Attachment #64054|0 |1 is obsolete| | Attachment #64055|0 |1 is obsolete| | Attachment #64056|0 |1 is obsolete| | Attachment #64057|0 |1 is obsolete| | Attachment #64058|0 |1 is obsolete| | Attachment #64059|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64217&action=ed… Bug 14826 - Update database Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5471] Quotes in tags cause moderation approval/rejection to fail
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Lee Jamison <ldjamison(a)marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64129|0 |1 is obsolete| | --- Comment #4 from Lee Jamison <ldjamison(a)marywood.edu> --- Created attachment 64208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64208&action=ed… [SIGNED OFF] Bug 5471 - Quotes in tags fail This patch makes changes to the tag moderation template and JavaScript to fix handling of tags with double or single quotes. This patch also moves the tags moderation JavaScript out of the template and into a separate JS file. To test you should have multiple tags awaiting moderation, including tags which contain double and single quotes. - Go to Tools -> Tags. - In the list of tags pending approval, test approving and rejecting tags, including those containing single or double quotes. - The state of the "Approve" or "Reject" buttons should correctly change according to the action you chose. - The label in the status column should update correctly. - In the "Check lists" form, submitting approved, rejected, and unclassified terms should result in the correct message. Signed-off-by: Lee Jamison <ldjamison(a)marywood.edu> Works correctly based on test plan. Tested using single- and double-quoted tags. Passes QA Tools. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5471] Quotes in tags cause moderation approval/rejection to fail
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Lee Jamison <ldjamison(a)marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '17

12 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Lee Jamison <ldjamison(a)marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison(a)marywood.edu --- Comment #6 from Lee Jamison <ldjamison(a)marywood.edu> --- Unfortunately, still having merge conflicts with the exact conflict message Katrin indicated previously. Note: I ran reset_all in kohadevbox to guarantee a clean devbox to apply it to. -- You are receiving this mail because: You are watching all bug changes.

1 0